From eea9f03ddd5f7b85ee6d5ff49fce2014e544c835 Mon Sep 17 00:00:00 2001 From: Anthony Minessale Date: Tue, 9 Feb 2016 10:45:29 -0600 Subject: [PATCH] FS-8816 #resolve [switch_hashtable_insert_destructor() returns 0/-1 but switch_core_hash_insert_destructor never checks this] --- src/switch_core_hash.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/switch_core_hash.c b/src/switch_core_hash.c index cdec290942..29427013b0 100644 --- a/src/switch_core_hash.c +++ b/src/switch_core_hash.c @@ -57,9 +57,11 @@ SWITCH_DECLARE(switch_status_t) switch_core_hash_destroy(switch_hash_t **hash) SWITCH_DECLARE(switch_status_t) switch_core_hash_insert_destructor(switch_hash_t *hash, const char *key, const void *data, hashtable_destructor_t destructor) { - switch_hashtable_insert_destructor(hash, strdup(key), (void *)data, HASHTABLE_FLAG_FREE_KEY | HASHTABLE_DUP_CHECK, destructor); + int r = 0; + + r = switch_hashtable_insert_destructor(hash, strdup(key), (void *)data, HASHTABLE_FLAG_FREE_KEY | HASHTABLE_DUP_CHECK, destructor); - return SWITCH_STATUS_SUCCESS; + return r ? SWITCH_STATUS_FALSE : SWITCH_STATUS_SUCCESS; } SWITCH_DECLARE(switch_status_t) switch_core_hash_insert_locked(switch_hash_t *hash, const char *key, const void *data, switch_mutex_t *mutex)