18644 Commits

Author SHA1 Message Date
Andrew Cassidy
8c540c6632 FS-8432 fixes timestamp type resolution, adds new header of type uint64 to carry microsecond resolution timestamp 2015-11-10 21:04:36 +00:00
Stanislav Sinyagin
de06bf086b FS-8427 Incompatible type for %ld in prinrtf 2015-11-09 21:54:00 +00:00
Anthony Minessale
6c7ed71a36 update 2015-11-09 15:35:52 -06:00
Anthony Minessale
f862c41c40 update 2015-11-09 15:13:19 -06:00
Anthony Minessale
f5c541a5c9 fix close file snafu 2015-11-09 15:13:19 -06:00
Anthony Minessale
ca49966f76 update 2015-11-09 15:13:19 -06:00
Anthony Minessale
65b7eeef52 commit 2015-11-09 15:13:19 -06:00
Peter Wu
48d6a5f6a8 switch_xml_decode: avoid NUL injection
strtol can parse negative values which opens the hole for a NUL
injection. The (invalid) entity "&#-256;" is parsed as 0xFFFFFF00 which
(when casted to a char) becomes 0.

Avoid this attack by using unsigned long integers. To avoid undefined
behavior due to negative shifts, restrict the upper bound of the code
points to the UTF-8 limits. (Add an assertion to make the Clang static
analyzer happy.)

Note: due to the specification of strtol, leading spaces and minus/plus
signs are also allowed, explicitly check for an integer. "&#0x1;" is
still accepted, but that is considered a minor issue.
2015-11-08 18:32:04 +01:00
Peter Wu
b683199688 switch_xml_set_attr: fix inconsistent state on error paths
Partially rewrite switch_xml_set_attr to fix memory leaks, uninitialized
argument values and use-after free warnings from Clang static analyzer.

Fixes these problems:

 - Add some comments and a new variable such that the code can more
   easily be audited / understood.
 - Always clear SWITCH_XML_DUP flag even if an error occurred to prevent
   free()'ing static strings on future invocations.
 - Keep the attribute list in a consistent state even if one of the
   memory allocation fails.
 - Keep allocation metadata in a consistent state when shrinking of the
   attribute lists fails. Previously the metadata was not updated,
   resulting in a wrong mapping from attributes to allocation flags.
 - Fix memory leaks when allocations fail.

Previous behavior: invalid memory accesses are possible after a memory
allocation failure, previous attributes may be lost.
New behavior: attributes list is always valid, a new attribute is either
set (or not), attributes can always be removed.
2015-11-08 18:30:44 +01:00
Anthony Minessale
1c8088a4a0 tweaks 2015-11-06 14:01:54 -06:00
Anthony Minessale
aa0b28e235 WIP not shabby auto vid settings 2015-11-06 14:01:54 -06:00
Anthony Minessale
828d6eaf01 first pass, add some funcs to conference and speed test features and fix bugs in ws.c for big payloads 2015-11-06 14:01:54 -06:00
Kirill Sysoev
b9278a8f0d FS-8416: Regex feature in param field 2015-11-05 22:17:54 +03:00
Mike Jerris
3f3b85596b Merge pull request #579 in FS/freeswitch from ~MARCELO1337/freeswitch-fs-8415:feature/FS-8415-send-180-ringing-for-early-media to master
* commit '7c3aed290dda715bb8d69c390b49f5557c762c3a':
  FS-8415 #resolve [support early with 180 using early_use_180=true]
2015-11-05 11:31:49 -06:00
Brian West
7d57063a14 FS-8404: if media engine will default to PCMU/PCMA if you don't specify any codecs 2015-11-05 11:30:02 -06:00
Anthony Minessale
38ff603766 FS-8417 #resolve [SIP offer with a=sendonly sometimes replies with a=inactive] 2015-11-05 10:43:19 -06:00
Marcel Haldemann
7c3aed290d FS-8415 #resolve [support early with 180 using early_use_180=true] 2015-11-05 11:13:33 +01:00
William King
a6cbe9034d FS-8377 Fix the handling of hiredis limit release when using an interval. The expectation for interval is to NOT decrement the limit. 2015-11-04 15:14:50 -08:00
Anthony Minessale
238722879b FS-8414 #resolve [Ptime unchanged on codec renegotiation] 2015-11-04 09:46:36 -06:00
Nathan Neulinger
b9be530c38 FS-8308 need to double encode if urlencoding json that is already encoded 2015-11-04 07:22:20 -06:00
Mark Lipscombe
6288af5ef1 FS-8413: Segfault calling session:getVariable(nil) in lua script
script calling session:getVariable() with a null variable
name will cause FreeSWITCH to segfault.

This change checks whether varname parameter to
switch_channel_get_variable_dup is non-NULL.
2015-11-04 17:33:11 +11:00
Bradley Jokinen
e96c2d4917 FS-8411 Replace ping_frame with video_ping_frame in a couple places that were missed 2015-11-03 09:27:21 -06:00
Anthony Minessale
b40454209b FS-8154 #resolve [Segmentation fault occurs while eavesdropping on video call] 2015-10-29 15:30:59 -05:00
Michael Jerris
b3dc9154d4 FS-8397: fix race condition inrementing event seq number 2015-10-29 10:28:21 -05:00
Emmanuel Schmidbauer
e6ae2e9bec FS-8392: change rtpmap payload to a number in dynamic range to allow both H263 and H263+ to be offered 2015-10-29 08:31:01 -04:00
Brian West
d744a18fd3 Merge pull request #550 in FS/freeswitch from ~DRAGOS_OANCEA/freeswitch-dragos:opus-fec-fix to master
* commit '65fd07923eb3d53931616fcd701a809e71f4243b':
  FS-8319: mod_opus: fix and cleanup of switch_opus_has_fec() and switch_opus_info().
2015-10-28 13:14:53 -05:00
Brian West
768a7ab6e5 Merge pull request #555 in FS/freeswitch from ~DRAGOS_OANCEA/freeswitch-dragos:opus-repacketization-toggle-fec to master
* commit 'd145111eed3505e11d9d0f0a891eab3945dddf36':
  FS-8344: mod_opus: toggle FEC on the last frame which is to be packed, so that FEC will be only present on the first SILK frame of the next Opus frame (Opus repacketization).
2015-10-28 13:12:17 -05:00
Mike Jerris
9edede6c08 Merge pull request #546 in FS/freeswitch from ~COREY BURKE/freeswitch:feature/FS-8281-expose-srtp-and-srtcp-crypto-keys to master
* commit '0316fdfcf1d2a72d1bad5dc9646371159173f93f':
  FS-8281: Expose SRTP and SRTCP crypto keys as channel vars
2015-10-27 19:13:25 -05:00
Corey Burke
0316fdfcf1 FS-8281: Expose SRTP and SRTCP crypto keys as channel vars
New vars are srtp_{local,remote}_crypto_key and srtcp_{local,remote}_crypto_key.
Allows decrypting packet captured media streams for debugging.
2015-10-27 16:33:49 -07:00
Brian West
cc25c46bfc Merge pull request #549 in FS/freeswitch from ~DRAGOS_OANCEA/freeswitch-dragos:opus-decoder-statistics to master
* commit 'ea65a31e307755dfbaae4e65221417a1d4583e04':
  FS-8313: mod_opus: show decoder stats at end of call (how many times it did PLC or FEC)
2015-10-27 11:47:12 -05:00
Anthony Minessale
e299489cfc FS-8391 #resolve [SDP parsing error for rtcp-fb] 2015-10-27 10:58:04 -05:00
Brian West
d8b3b52aee Merge pull request #565 in FS/freeswitch from ~BRADLEYJOKINEN/freeswitch:FS-8373 to master
* commit 'c3a59c4b2261ae0b7e0b251057846af27dbf83f2':
  FS-8373 Improve quality of recordings when using fast encoding
2015-10-26 13:34:56 -05:00
Mike Jerris
6b5b1a3d86 FS-8389: [build] Fix msvc 2015 build warnings 2015-10-26 13:45:48 -04:00
Brian West
37263d47d5 Merge pull request #566 in FS/freeswitch from ~BRADLEYJOKINEN/freeswitch:FS-8380 to master
* commit '216e79f799127155a15a75cbebbe67061c03cb06':
  FS-8380 Improve mod_av's handling of vw and vh core file params
2015-10-26 10:21:51 -05:00
Anthony Minessale
5b4c725963 FS-8384 #resolve [Locking contention in mod_conference] 2015-10-23 13:58:40 -05:00
Chris Rienzo
a711b7cd88 FS-8370 #resolve [mod_rayo] found another place in <prompt> where a message was freed after being queued for delivery. This resulted in a freed object being serialized, crashing FS. 2015-10-22 23:11:31 -04:00
Anthony Minessale
e351f3565d FS-8115 #comment test latest patch 2015-10-22 15:37:21 -05:00
Anthony Minessale
f6427a5f92 FS-8382 #resolve [Segfault with inbound-proxy-media enabled] 2015-10-22 15:02:38 -05:00
Anthony Minessale
8f93fd5590 FS-8381 #resolve [Reset JB if period loss is too high] 2015-10-22 13:26:53 -05:00
Anthony Minessale
7e47db6b9b FS-8130 regression causing excessive mark bit detection in some cases 2015-10-22 13:07:18 -05:00
Mike Jerris
78c8a5ffba FS-8378: [mod_esf] fix crash when using esf_page over loopback when transcoding 2015-10-22 12:59:33 -05:00
Mike Jerris
1968453e32 FS-8378: refactor a bit to clarify code and get better debug in gdb 2015-10-22 12:57:42 -05:00
Bradley Jokinen
216e79f799 FS-8380 Improve mod_av's handling of vw and vh core file params
This allows for the core file params vw and vh to be used to modify the
resolution of recordings. If the specified resolution does not match
the resolution of the call being recorded, the video will be scaled.
2015-10-22 12:15:11 -05:00
William King
39f6d107ac FS-8377 Adding expanded support for limit_* functionality for mod_hiredis 2015-10-21 14:56:21 -07:00
Anthony Minessale
b9bcd7429d FS-8375 #resolve [Add member id to conference liveArray event] 2015-10-21 14:00:48 -05:00
Anthony Minessale
116c4aa916 up default max jb size to 50 2015-10-21 11:50:14 -05:00
Mike Jerris
847fe0f476 Merge pull request #535 in FS/freeswitch from ~COREY BURKE/freeswitch:bugfix/FS-8286-improve-debug-logging-for-info-level to master
* commit '3a9e7f08b4757aeaa33537658379f3964104cb7d':
  FS-8286: Minor debug log level tweaks
2015-10-21 11:43:18 -05:00
Anthony Minessale
072f269ee7 FS-8372 #resolve [Wrong response to RTP/SAVPF without DTLS] 2015-10-21 11:28:37 -05:00
Bradley Jokinen
c3a59c4b22 FS-8373 Improve quality of recordings when using fast encoding 2015-10-21 10:03:59 -05:00
Anthony Minessale
95b0f0c88a FS-8368 one more 2015-10-20 18:13:28 -05:00