Commit Graph

6627 Commits

Author SHA1 Message Date
Jeff Lenk 24c13adfaf FS-5483 --resolve 2013-05-29 09:32:24 -05:00
Steve Underwood 4fba20c787 Something stupid that way went 2013-05-29 17:00:57 +08:00
Steve Underwood 3ea625c6ae More movement towards colour FAXing 2013-05-29 14:47:48 +08:00
Steve Underwood 3519e0f4c3 More tweaks towards colour FAXing 2013-05-29 10:07:08 +08:00
Steve Underwood 3b595efc60 More tweaks towards colour FAXing 2013-05-29 09:53:56 +08:00
Steve Underwood 0b6c53217a Moves towards colour FAX 2013-05-29 09:31:58 +08:00
Travis Cross d7b139f3b4 Avoid dereferencing potential null value 2013-05-28 03:55:48 +00:00
Travis Cross 3217442d0e Remove assignment without effect 2013-05-28 03:46:53 +00:00
Travis Cross e887cecb5e Avoid dereferencing potential null value 2013-05-28 03:41:44 +00:00
Travis Cross 2dea51ad58 Handle potential malloc failure better 2013-05-28 03:40:58 +00:00
Travis Cross ef13a63447 Fix unlikely memory leak in ESL 2013-05-28 03:01:49 +00:00
Travis Cross a5397e5980 Remove assignment without effect in fs_cli 2013-05-27 21:07:56 +00:00
Travis Cross f00b77597f Avoid dangling reference at end of fs_cli
Not that it really matters since we're returning to the OS momentarily
at that point anyway.
2013-05-27 21:07:52 +00:00
Jeff Lenk 757b792324 FS-5479 --resolve 2013-05-27 09:21:43 -05:00
Jeff Lenk d21b960899 fix unused parameter warning on windows 2013-05-27 09:18:56 -05:00
Travis Cross b30dde34ec Remove self-assignment without any effect
clang:

  error: explicitly assigning a variable of type 'uint16_t' (aka 'unsigned short') to itself [-Werror,-Wself-assign]
2013-05-27 06:09:06 +00:00
Travis Cross 8c37db140e Handle a failure of strerror_r
This fixes the build on gcc-4.7.3.  The build was breaking with:

  error: ignoring return value of 'strerror_r', declared with attribute warn_unused_result [-Werror=unused-result]
2013-05-25 19:05:34 +00:00
Travis Cross 6d5018007b Add missing text editor local variable blocks 2013-05-25 19:05:34 +00:00
Stefan Knoblich cb9090dc93 esl: Don't abort the esl_listen() loop(s) if accept() returns with errno == EINTR
ivrd doesn't use sigaction + SA_RESTART for SIGCHILD. An exiting
child process will interrupt accept() in the parent to handle
the signal, which makes accept() return -1 (errno = EINTR) after
the sighandler function returns.

Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-23 02:07:55 +02:00
Stefan Knoblich ca1d407921 ivrd: fflush() stdout before entering esl_listen()
Fixes repeatedly printing the 'Starting forking listener' message,
if stdout has been redirected into a logfile (for example).

Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-23 02:05:25 +02:00
Stefan Knoblich 8019af49a4 ftmod_libpri: Fix possible NULL-ptr dereference crash in on_restart(_ack)()
Catch single channel RESTART/RESTART ACK events for non-B-channels,
that would lead to a NULL pointer dereference, because those do not have
per-channel private data (chan->call_data = chan_priv == NULL).

Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-21 17:50:54 +02:00
William King b4209ca93b Theoretical memory leak where if attr_init failed, then check would have still been malloc'd but not used. 2013-05-18 20:42:03 -07:00
William King e2ea6e58c8 Minor code cleanup. calling va_start without calling va_end doesn't leak does it? Either way, it's fixed now. 2013-05-18 20:15:55 -07:00
Steve Underwood 37d109b107 Some tweaks to the image translate code 2013-05-16 02:28:20 +08:00
Anthony Minessale 75c3b8b83e FS-5325 force rebuild 2013-05-14 07:44:34 -05:00
Jeff Lenk d466316ace FS-5325 windows compile 2013-05-10 17:31:01 -05:00
Anthony Minessale 5761624f5a FS-5325 2013-05-10 12:55:26 -05:00
Jeff Lenk b85c24df08 spandsp windows fix syntax for gettimeofday 2013-05-10 12:46:03 -05:00
Stefan Knoblich 39fb4544dd FreeTDM: ftmod_misdn uses clock_gettime() which is in librt, add a check
Fixes -Wl,-z,now / -Wl,-z,defs errors about undefined symbols.

Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-10 19:04:10 +02:00
Stefan Knoblich 80a2b76620 FreeTDM: Make libpri pri_version() check -Wunused-but-set-variable safe
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-10 19:04:10 +02:00
Stefan Knoblich 284ce5407b FreeTDM: Move external ftmod_* library dependencies to _LIBADD
Making the build -Wl,--as-needed safe.
Tested on Centos 5.x + Gentoo.

Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-10 19:04:10 +02:00
Stefan Knoblich b793ccbe43 FreeTDM: Fix implicit conversion between enumeration types error
Full clang error message:

  error: implicit conversion from enumeration type 'ftdm_bool_t' to
  different enumeration type 'ftdm_status_t' [-Werror,-Wconversion]

Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-10 19:04:10 +02:00
Stefan Knoblich cbf22d8a32 FreeTDM: Silence -Wtautological-compare warnings emitted by clang
Fixes "warning: comparison of unsigned expression >= 0 is always true".

Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-10 19:04:09 +02:00
Stefan Knoblich ae58a4c1ba FreeTDM: Use ftdm_unused_arg() to silence -Wunused-argument warnings
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-10 19:04:09 +02:00
Steve Underwood 46ec57c415 The gettimeofday() function spandsp provided for Windows apparently falls over
after 25 hours. I guess not many people are inserting header lines on FAX pages.
Hopefully this update fixes the problem.
2013-05-10 11:54:20 +08:00
Anthony Minessale 79230a5d8a FS-5325 i'll put the nonblocking in but I still think this is a problem with openssl, a short read is not there every single time you connect, When the lib is in full blocking mode it should be handling the complicated actions internally. As complicated as socket programming is, async ssl is even worse because it requires you to do your own buffering and attemps to read may fail waiting for you to write or vice-versa which should have been handled for us in the lib. non-interruptable syscalls are getting pretty outdated and not enabling it is much less complex than making every socket app on earth be non-blocking 2013-05-09 12:56:42 -05:00
Anthony Minessale b2a9c71df6 FS-5325 2013-05-07 11:30:37 -05:00
Stefan Knoblich 81702d18fb FreeTDM: Add ftdm_unused_arg() macro to silence "unused parameter" compiler warnings
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-06 17:50:10 +02:00
Jeff Lenk b4826c1a7f another esl managed tweak 2013-05-04 12:43:19 -05:00
Jeff Lenk abbe992e1c tweak windows esl managed - removing mixed mode and any from the solution - this should remove some of the ambiguity around building 2013-05-04 12:15:04 -05:00
Anthony Minessale 442a53ae3c rebuild 2013-04-26 08:41:49 -05:00
Anthony Minessale 471b3d33fd add tcp keepalive where possible 2013-04-25 13:33:17 -05:00
Anthony Minessale fddad1da06 FS-5343 --resolve 2013-04-24 12:09:35 -05:00
Anthony Minessale 35b584bd19 FS-5325 this should prefer v4 addrs to avoid the blocking on connect as well so you can use the dns name again 2013-04-24 10:49:04 -05:00
Anthony Minessale c6e9b9941c FS-5325 2013-04-24 10:12:42 -05:00
Steve Underwood 6e6272a7b5 More changes towards colour FAX support 2013-04-22 08:31:30 +08:00
Steve Underwood abd03ceefe Tweaks to the V.17 modem 2013-04-21 23:13:51 +08:00
Steve Underwood df4d264a6e Fixed a new error introduced when scrunching colour images down to bi-level 2013-04-21 22:47:08 +08:00
Steve Underwood 88b3b54ef4 More movement towards colour FAXing 2013-04-21 22:02:09 +08:00
Anthony Minessale 8e49f7a556 FS-3612 --resolve This got reverted by accident. Funny that it took a year for someone to notive =0 2013-04-19 15:31:05 -05:00