Commit Graph

162 Commits

Author SHA1 Message Date
Travis Cross 180d081be4 Use buffered printers in fs_cli
Now that all output should end in a newline, we don't need to play
tricks with getting certain escape codes out ahead of buffered output.

This updates what we tried to do in commit
991b83d23c.

This partially reverts commit
8056125077.
2014-03-28 00:01:33 +00:00
Travis Cross 11f4628cae Reenable the new EL_REFRESH mechanism 2014-03-27 23:09:06 +00:00
Travis Cross 59f80c9e4f Handle bodies not ending in newlines w/EL_REFRESH
The issue is that sofia siptrace output doesn't end each line with a
newline.  Instead it sends a separate newline afterward, which comes
in as a separate event body.  With the new EL_REFRESH code in effect
the line is being cleared after the siptrace output has been written
but before that next newline comes in.

With our own refresh code this doesn't happen because of slight
differences in where the stdio buffers get flushed compared to where
the output of clear_line() ends up.

This is a bit of a clumsy workaround.  But we'll fix it first, then
refactor.
2014-03-27 23:06:07 +00:00
Travis Cross 3bc51dfff9 Turn on the fancy fs_cli with a modern libedit
We turn ON the features with a newer libedit.

This fixes commit 4f54f912c3.
2014-03-27 17:35:35 +00:00
Travis Cross 4f54f912c3 Add back terminal detection for old libedits
Using the system libedit means that libedit will again make absolute
movements on certain kinds of terminals.  Older versions of libedit
without EL_PROMPT_ESC miscalculate the length of the prompt.
Combined, this results in the cursor ending up in the wrong place.

We knew this was a possibility when we moved to system libedit, and
we're OK with it.  We certainly lived without this fancy prompt
feature for a long time.

This change puts back in place detection of the terminal type when
EL_PROMPT_ESC isn't available.  On these older versions of libedit,
we'll only enable the fancy features when we know that libedit will
only make relative movements and not tickle the bug.

This partially reverts commit:
b9b77bd615
2014-03-27 17:19:55 +00:00
Travis Cross dc093d179e Drop use of libedit EL_REFRESH in fs_cli for now
Newer versions of libedit provide an EL_REFRESH mechanism for
redrawing the prompt.  We had previously written our own code to
handle this.  In theory handing this over to libedit should be better.

Unfortunately when using EL_REFRESH the output of sofia siptrace isn't
showing up.  We're working on that, but for now we're just force own
our redrawing code to be used instead.
2014-03-27 12:20:43 +00:00
Brian West c7bd862e9a FS:353: correct #if check for libedit function capability 2014-03-24 16:18:03 -05:00
James Le Cuirot 8574988c3a Completely unbundle libedit
FS-353

Signed-off-by: Travis Cross <tc@traviscross.com>
2014-03-24 12:39:59 +00:00
Travis Cross cdc358c505 Add comment to distant #endif
FS-353
2014-02-23 22:33:28 +00:00
James Le Cuirot d996974faa Fix building without libedit
Signed-off-by: Travis Cross <tc@traviscross.com>

FS-353
2014-02-23 22:33:20 +00:00
Anthony Minessale b5821c1594 tweak event queue size on event socket and speed up fs_cli a little to keep up on busy logging env 2014-01-23 21:26:56 +05:00
Anthony Minessale 3ff0aaa0be FS-5653 --resolve 2014-01-07 00:38:48 +05:00
Anthony Minessale 2e74cf79fc FS-5617 --resolve 2013-07-19 13:29:05 -05:00
Jeff Lenk 5fc2bc9993 FS-5588 --resolve windows compiler fixes 2013-07-09 07:53:56 -05:00
Ken Rice 22baa51acc FS-2816 --resolve 2013-07-06 22:04:06 -05:00
Nathan Neulinger 32adc789f6 make noexpandtab explicit in all vim modelines other than xml files 2013-06-25 11:50:17 -05:00
Travis Cross a5397e5980 Remove assignment without effect in fs_cli 2013-05-27 21:07:56 +00:00
Travis Cross f00b77597f Avoid dangling reference at end of fs_cli
Not that it really matters since we're returning to the OS momentarily
at that point anyway.
2013-05-27 21:07:52 +00:00
Anthony Minessale 5ee719d1d9 FS-5271 --resolve 2013-04-08 12:53:58 -05:00
Anthony Minessale bd25514307 add FS_CLI_COLOR=false env and -n/--no-color command line flag to turn off colored banner 2013-02-20 13:51:53 -06:00
Ken Rice 9c975033a7 FS-4844 --resolve 2013-02-07 13:16:19 -06:00
Jeff Lenk 77eabbbdf7 FS-4694 --resolve 2012-10-17 09:17:16 -05:00
Anthony Minessale c51aebf621 FS-4694 --resolve 2012-10-16 19:03:29 -04:00
Stefan Knoblich 8075b01569 Fix error in switch_core_screen_size() and screen_size() fallback code.
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2012-09-26 17:21:05 +02:00
Michael Jerris ee50ed23ab FS-4645: --resolve fix build error in fs_cli 2012-09-25 14:19:00 -04:00
Anthony Minessale 03c981bf72 add smaller banner for teeny tiny terminals 2012-09-24 14:59:09 -05:00
Michael Jerris 4ff9b2f102 revert fb2ffbafe2 2012-09-24 15:38:06 -04:00
Travis Cross fb2ffbafe2 Add configure flags to moderate the ClueCon nags
The default remains the same: we show the huge ClueCon nag banner on
startup and in fs_cli.

However, if you pass --disable-huge-cluecon-nag, no banner will be
shown.

If you pass --enable-modest-cluecon-nag, a modest text-based ClueCon
reminder will be shown instead.
2012-09-23 07:49:26 +00:00
Jeff Lenk e4e044e310 FS-4566 --resolve Show fs_cli banner in color(windows) 2012-09-02 21:57:20 -05:00
Jeff Lenk 0807b39c8d FS-4543 --resolve thanks Peter 2012-08-17 19:31:47 -05:00
Anthony Minessale f454b79b9b fix color coding to be OS appropriate 2012-08-16 13:04:33 -05:00
Anthony Minessale 27155bcb71 come to ClueCon its in one month 2012-07-10 12:05:26 -05:00
Mitch Capper 6f87ac55d6 fs_cli: add batch mode
Signed-off-by: Travis Cross <tc@traviscross.com>
2012-04-08 16:54:40 +00:00
Anthony Minessale b80a3a3439 set session loglevel as well in fs_cli when doing 'console loglevel info' also now implies '/log info' locally 2012-04-02 11:58:00 -05:00
Travis Cross b9b77bd615 fs_cli: make enhanced fs_cli features work on all TERMs
FS-3815 --resolve

This is a workaround for the fact that libedit counts terminal control
characters when calculating the length of the prompt.  By not using
absolute positioning, we avoid the issue.

Thanks to Ivan Isaev for the workaround and testing.
2012-01-31 18:42:47 +00:00
Travis Cross f4968d0e6e fs_cli: style (FS-3815) 2012-01-18 22:44:44 +00:00
Anthony Minessale dfb2dfd29e umm ya, the thread stack size is in bytes not kbytes 2011-12-20 17:14:38 -06:00
Brian West da10fe86a1 really now 2011-10-28 16:51:02 -05:00
Jeff Lenk 8aad82d653 FS-3647 --resolve fs_cli crash on windows 2011-10-28 08:41:17 -05:00
Travis Cross 26cd927cb0 fs_cli: only enable new features on supported terminals
This is a workaround to an issue where editline counts non-printable
control characters.  See issue FS-3606.
2011-10-27 15:15:59 +00:00
Michael Jerris cbc92936f3 allow ;; seperated commands in fs_cli -x 2011-10-26 15:35:03 -04:00
Jeff Lenk 1afda8fb39 FS-3601 --resolve fix fs_cli for recent changes with windows 2011-10-07 09:03:09 -05:00
Travis Cross b8eaec001a whitespace cleanup 2011-09-27 05:57:49 +00:00
Jeff Lenk 16a0a2ed6d another windows fix for fs_cli changes 2011-09-26 21:41:35 -05:00
Travis Cross 02481cabbf fs_cli: comply with -Wwrite-strings 2011-09-26 22:00:08 +00:00
Travis Cross 8056125077 fs_cli: fix siptrace output
This partially reverts commit 991b83d23c.
2011-09-26 21:34:52 +00:00
Jeff Lenk 1244e55632 another fs_cli windows fix 2011-09-26 11:47:26 -05:00
Jeff Lenk 34827a892c fix fs_cli for windows after recent changes - may need more work 2011-09-26 09:15:12 -05:00
Travis Cross a2d6a041eb fs_cli: ask less of the terminal; fix ctrl-l behavior 2011-09-24 03:07:34 +00:00
Travis Cross fe60938686 fs_cli: exclude last character in buffer on redisplay 2011-09-23 22:40:02 +00:00