The new C compiler breaks a lot of things. snprintf and timespec now exist, and redefining causes an error.
Many more things are warnings, so warnings-as-errors will fail - remove it from some projects for now.
V8: don't pass VS version to build batch file.
mod_sofia: Config has too-long if/elseif chain. Break this up to avoid "parser stack overflow; program too complex".
Add mod_conference.h to project and dir to includes.
In exec_user_method() report ERROR LOG to console in cases exceptions occurs,
like if any of class/method/userMethod->arg is null or for any reason which
sets status to SWITCH_STATUS_FALSE because that prevents loading mod_java and
users don't have clue why it is failing to load.
With this patch error logs can tell why method failed to execute.
FS not able to load mod_java because in load_config switch_status_t status
is not initialised and in some conditions status is not gets set ever
resulting returning garbage value, resulting failuar to load mod_java.so.
With this patch status is set to SWITCH_STATUS_SUCCESS so in case everything
is loaded it can load mod_java else status is set to SWITCH_STATUS_FALSE(which
is already covered).
In the FreeSWITCH core, the return value of switch_case_db_test_reactive
is ignored, but it is usable in LUA modules (and other bindings via
SWIG). The LUA API example[1] shows how to check the return value, but
that example miserably fails if the database did not exist before.
Changes:
- Document the expected behavior of the test_reactive function.
- Assert that test_sql and sql_reactive are both given. If either
query is not given, the caller is using the wrong API.
- When SCF_AUTO_SCHEMAS is cleared, use the return value of the
test_sql execution. Does anybody use this? Why not remove it?
- Do not unconditionally return SWITCH_FALSE when test_sql fails,
instead allow it to become SWITCH_TRUE when reactive_sql passes.
- Remove the unnecessary test_sql check for SCDB_TYPE_CORE_DB
(this is now enforced through an assert check). (+reindent)
- Clarify the error message of drop_sql, prepending "Ignoring" to
the "SQL ERR" message.
- LUA: Do not print "DBH NOT Connected" if the query fails. This was
the initial source of confusion.
[1]: https://confluence.freeswitch.org/display/FREESWITCH/Lua+API+Reference
