Commit Graph

26712 Commits

Author SHA1 Message Date
William King 5f3e98beb4 Fix a use after free in a 'theoretical' case in switch_cache_db_persistant_execute_trans_full where the pre_trans_execute statement fails, but SQLSetAutoCommitAttr succeeds 2014-04-30 14:37:17 -07:00
Michael Jerris 6add88b43f check return value for es_say_general_count 2014-04-30 16:43:35 -04:00
Michael Jerris ef18915ca5 make sure old_pid_buffer is null terminated 2014-04-30 16:36:14 -04:00
Michael Jerris a1a397420e fix leaked body in error case 2014-04-30 16:10:08 -04:00
Michael Jerris 23b3e172d5 don't leak file handle if fd = 0 2014-04-30 15:56:36 -04:00
Michael Jerris 6f16e0d3da don't leak if first realloc fails but second one succeeds 2014-04-30 15:53:26 -04:00
Michael Jerris 068ad205b7 split this into 2 functions so its clear if this function allocates or not 2014-04-30 15:48:23 -04:00
Steve Underwood b205313f4f More fixes from Coverity scans 2014-05-01 02:56:53 +08:00
Michael Jerris 942215637a make sure receive buffer is always null terminated 2014-04-30 13:49:58 -04:00
Michael Jerris ac9741b579 don't leak xml string in dl_logger 2014-04-30 13:44:59 -04:00
Michael Jerris 0b8d2c5d65 add better bounds checking in dtmf_accepting array to avoid buffer overrun in mod_voicemail_ivr 2014-04-30 13:31:06 -04:00
Michael Jerris a9a852477a fix read beyond buffer length error 2014-04-30 13:25:29 -04:00
Steve Underwood 32c0bfde6b A couple more Coverity issues fixed 2014-05-01 01:19:28 +08:00
Travis Cross c37d0dd6f0 Bisect with make -j 2014-04-30 17:10:30 +00:00
Travis Cross 43c9f6d5f9 Don't unset CCACHE_DIR when bisecting 2014-04-30 17:04:30 +00:00
Michael Jerris e57484af9b FS-6497: --resolve fix for loop initial declaration not allowed 2014-04-30 12:16:02 -04:00
Steve Underwood 0ebc79457e Another couple of Coverity related cleanups 2014-04-30 22:51:59 +08:00
Michael Jerris 8ad8ae8e86 remove generated file from tree 2014-04-30 10:34:08 -04:00
Steve Underwood b8bd000bdd More elimination of warnings with clang 2014-04-30 22:27:29 +08:00
Steve Underwood bfacd58fa7 Eliminate some clang warnings 2014-04-30 22:18:46 +08:00
Chris Rienzo c36e63026c mod_http_cache: CID 1025858: Thread deadlock (ORDER_REVERSAL) 2014-04-30 10:08:00 -04:00
Michael Jerris e98045841e gracefully handle allocation failure 2014-04-30 08:55:39 -04:00
Michael Jerris 2e8572acb5 we always have the session in the dialplan function 2014-04-30 08:51:52 -04:00
Michael Jerris b3bfa563ae we always have the caller profile at this point, if for some reason we don't just instead of crashing 2014-04-30 08:50:29 -04:00
Michael Jerris 7508481597 we always have the seesion in the app function 2014-04-30 08:46:11 -04:00
Michael Jerris 9bf98d0dd3 remove useless checks of array == 0 2014-04-30 08:43:57 -04:00
Michael Jerris 6e23eab0cc do set compiler flag that compiler doesn't support 2014-04-30 08:33:09 -04:00
Steve Underwood 21a2e19470 Eliminated another Coverity issue 2014-04-30 14:41:06 +08:00
Steve Underwood ba6457bbe9 Some more coverity issues cleaned up 2014-04-30 13:10:59 +08:00
Steve Underwood dac846cc7e Cleared some simple Coverity issues 2014-04-30 12:42:46 +08:00
Anthony Minessale 2cdae46b19 FS-6476 regression where sock would sometimes drop while reading logical frames 2014-04-29 18:25:05 -04:00
William King af32ca00e3 Correction to commit 0ba59aa6c2 using the correct variable in tel uri param parsing for mod_sofia 2014-04-29 15:23:24 -07:00
Michael Jerris 529099f15c silence incorrect warnings about null pointer derference and remove unused code 2014-04-29 14:34:49 -04:00
Anthony Minessale d0de8c0bc6 add heartbeat_use_scheduler variable to force the heartbeat to use the scheduler rather than the media stream and also make it auto-chage between modes when going in and out of the media path 2014-04-29 04:20:51 +05:00
Travis Cross cc928b2315 Add helper for running git bisect 2014-04-28 22:31:18 +00:00
Michael Jerris 6e41898517 this should never happen, but just in case, this will at least calm coverity 2014-04-28 16:30:19 -04:00
Michael Jerris 7e2499355a handle null 'status' passed to 'switch_channel_perform_presence' more gracefully 2014-04-28 16:21:45 -04:00
Michael Jerris a5f680810d only enable passthru_ptime_mismatch when set to a true value, not when it is set to any value 2014-04-28 16:17:56 -04:00
Michael Jerris d9b5bfaa7f only enable passthru_ptime_mismatch when set to a true value, not when it is set to any value 2014-04-28 16:12:10 -04:00
Michael Jerris a044b3b64b remove unused var ocp 2014-04-28 16:06:39 -04:00
Michael Jerris e7107f616f if we can't open /dev/null, you have much bigger issues to deal with 2014-04-28 16:02:39 -04:00
Michael Jerris 34c967707d improve null checks 2014-04-28 15:49:57 -04:00
Michael Jerris 1b43fa85b5 remove useless variable 2014-04-28 15:19:19 -04:00
Michael Jerris 7a7c275445 remove useless statement 2014-04-28 15:16:03 -04:00
Michael Jerris 0cba8b39c3 improve error checking for null path 2014-04-28 15:12:02 -04:00
Michael Jerris 8d10e65b79 fix bitwise flag unsetting 2014-04-28 15:06:39 -04:00
Michael Jerris 4828ecd7fd remove unused variable 2014-04-28 15:00:22 -04:00
Michael Jerris 95d4d0031c don't set variable we don't use, and fix off by 1 buffer overflow in 1 case 2014-04-28 14:46:05 -04:00
Michael Jerris dbaf49926c remove unnecessary null check, we would have crashed already if that strdup failed 2014-04-28 14:38:38 -04:00
Brian West 5c07c3eb03 don't use memory after free when using naptr with mod_enum with multiple routes 2014-04-28 13:03:09 -05:00