William King
|
8803804f90
|
Removing unused code
|
2013-05-24 19:53:10 -07:00 |
|
William King
|
47c6981a9f
|
More explicit and defensive code so if the init fails we know we handling this pointer safely, because rc_config_init will free the pointer if there was a problem, but it will not set the pointer to NULL.
|
2013-05-24 19:49:20 -07:00 |
|
William King
|
6320042f6b
|
Another location where mod_rtmp would leak memory.
|
2013-05-24 19:45:24 -07:00 |
|
William King
|
83ae82fd2d
|
Fix improper handling of a double linked list that could have caused a memory leak.
|
2013-05-24 19:42:02 -07:00 |
|
William King
|
b3aea78730
|
Appears to have been a copy paste error because this doesn't do what the api claims, and it also leaks the reference to the new node.
|
2013-05-24 19:35:43 -07:00 |
|
William King
|
8a743cb2f3
|
Fixing a memory leak. name needs to be freed since it's being strdup'd lower.
|
2013-05-24 19:31:40 -07:00 |
Anthony Minessale
|
aecd186ba5
|
FS-5470 --resolve
|
2013-05-24 09:37:40 -05:00 |
|
Anthony Minessale
|
dc13cb847f
|
FS-5466 --resolve
|
2013-05-24 09:14:26 -05:00 |
Mariusz Czułada
|
e44316d3ea
|
FS-5042 changed event body creation
|
2013-05-24 09:02:23 -05:00 |
Raymond Chandler
|
d00ed860a1
|
FS-4871: reduce logging a bit
|
2013-05-24 08:34:44 -05:00 |
Jeff Lenk
|
4b54ec078b
|
FS-5389
|
2013-05-24 08:34:43 -05:00 |
|
Jeff Lenk
|
b214af4ccf
|
FS-5389 --resolve
|
2013-05-24 08:34:43 -05:00 |
|
Raymond Chandler
|
1e6d7ea113
|
FS-4871 --resolve
|
2013-05-24 08:32:46 -05:00 |
|
Anthony Minessale
|
22076b7b6f
|
FS-5453 --resolve
|
2013-05-24 08:13:55 -05:00 |
|
Anthony Minessale
|
9c98829aab
|
FS-5453 --resolve this is a different issue, we just have to hangup the loopback channel so the loopback and the sip don't both execute the extension
|
2013-05-23 09:59:18 -05:00 |
|
Anthony Minessale
|
0060313ea1
|
swig
|
2013-05-23 09:55:52 -05:00 |
|
Anthony Minessale
|
18ac2a2540
|
FS-5042 --resolve
|
2013-05-23 08:07:26 -05:00 |
|
Anthony Minessale
|
3d2eb20a28
|
FS-5453 --resolve
|
2013-05-23 08:06:52 -05:00 |
|
Anthony Minessale
|
c08622235d
|
FS-5402 --resolve the problem is ent originate has many channels and many causes to parse so we need to check it against all the causes
|
2013-05-22 11:01:59 -05:00 |
|
Anthony Minessale
|
666ba36e57
|
FS-5360 change defaults
|
2013-05-22 10:20:57 -05:00 |
|
Anthony Minessale
|
aed693b9e5
|
FS-5436 --resolve
|
2013-05-21 19:39:21 -05:00 |
|
Anthony Minessale
|
b73e2c51bb
|
FS-5402 revert wait till tomorrow
|
2013-05-21 13:29:05 -05:00 |
|
Anthony Minessale
|
b6561f2535
|
FS-5402
|
2013-05-21 13:22:35 -05:00 |
|
Anthony Minessale
|
1b6860d8e3
|
FS-5453 --resolve
|
2013-05-21 12:02:12 -05:00 |
|
Anthony Minessale
|
e4f7fda044
|
FS-5457
|
2013-05-21 10:22:02 -05:00 |
|
Anthony Minessale
|
e2da2e19c3
|
FS-5376 --resolve
|
2013-05-21 10:04:58 -05:00 |
|
Anthony Minessale
|
fb3eb97568
|
FS-5242
|
2013-05-21 10:03:36 -05:00 |
|
Anthony Minessale
|
4bdd2a7f84
|
FS-5211 --resolve
|
2013-05-21 09:30:06 -05:00 |
|
Anthony Minessale
|
36116944a7
|
FS-5360
|
2013-05-20 12:23:13 -05:00 |
|
Anthony Minessale
|
3a0ec14130
|
getting read_impl too soon here
|
2013-05-20 11:22:54 -05:00 |
|
William King
|
4192bf3370
|
Minor code cleanup. calling va_start without calling va_end doesn't leak does it? Either way, it's fixed now.
|
2013-05-18 20:15:14 -07:00 |
|
William King
|
79e3de3e55
|
full_contact must be freed by sofia. There isn't a chance of this having blown anything up, but Coverity is right that this should be initialized with NULL to be safe against future refactors.
|
2013-05-18 19:13:44 -07:00 |
|
William King
|
c80d768004
|
My bad. some how a make didn't catch this issue after a cleanup refactor. In this instance buf is being treated as an 8 byte number, not a pointer.
|
2013-05-18 17:46:50 -07:00 |
|
William King
|
f3393ef362
|
Coverity reported an Uninitialized pointer read. Upon further digging it appears that there is a code path where incoming packets can come in out of order, so this section of code tries to see if it can find the missed packets. As per FS-5202 there is a case where under heavy load the packet exists, and has most of the packet parsed, but still has a NULL pointer for the packet buffer. These two lines would at least help detect the edge case.
|
2013-05-18 17:35:07 -07:00 |
|
William King
|
bd4ea84242
|
Edge case for when you are subscribing to presence on a valet parking lot. In which case there would be a small leak.
|
2013-05-18 17:07:31 -07:00 |
|
William King
|
97286e10cd
|
Possible leak if someone were to try and add extra headers to a channel that had either an inbound info on that session or the session were to be deflected. I don't see a way that these extra headers could be added outside of a C module subscribing to the session states, but just to make sure I'm adding these so that just like other extra header locations it's cleaned up.
|
2013-05-18 17:01:27 -07:00 |
|
William King
|
14f48a6a7a
|
Alice meet rabit hole. There is a leak here on every invite that comes back from a status 180 when the other side is not FS, but you have presence enabled. Thanks to Coverity scan for location this condition. This 'might' not have been leaking if sofia was automatically freeing this when the sofia object was destroyed, but all other locations where sip_header_as_string where called they were all followed by a su_free, so I assume not.
|
2013-05-18 16:36:41 -07:00 |
|
William King
|
d61d395e8d
|
If the mod_sofia global presense hash is null, then make sure to free the matches variable before going to done.
|
2013-05-18 16:06:15 -07:00 |
|
William King
|
dac6ce1b45
|
FS-5443: --resolve leaked because the JS api's copy and return new malloc'd pointers.
|
2013-05-18 15:47:51 -07:00 |
|
William King
|
9ce6ce082f
|
When message events were added, the debug field name was overlooked. This would have only been hit when debug level was above 'DEBUG1' and at that point it would have incorrectly chosen debug display names.
|
2013-05-18 15:11:14 -07:00 |
|
William King
|
4fc1369a1b
|
Minor typo. User is being passed into this fuction as a long pointer, not a long.
|
2013-05-18 14:30:43 -07:00 |
|
William King
|
49303fdabc
|
read() does not NULL terminate statbuf, but strstr expects statbuf to be null terminated.
|
2013-05-18 14:27:00 -07:00 |
|
William King
|
48f423db40
|
This was writing a null one space to the right, outside of the malloc'd buffer. On further review this uses apr_vsnprintf which always returns null terminated.
|
2013-05-18 13:39:12 -07:00 |
|
Jeff Lenk
|
dec5a592ca
|
FS-5434 --resolve
|
2013-05-17 21:44:13 -05:00 |
|
Anthony Minessale
|
bf688a87aa
|
fix silence_stream size bug
|
2013-05-17 16:12:13 -05:00 |
|
William King
|
fc42d93ddf
|
FS-5441: --resolve
|
2013-05-17 12:40:04 -07:00 |
|
Anthony Minessale
|
c8ef74055a
|
FS-5430 --resolve
|
2013-05-15 09:27:44 -05:00 |
|
Anthony Minessale
|
3fe3a0091c
|
FS-5418 --resolve
|
2013-05-15 08:09:07 -05:00 |
|
Anthony Minessale
|
88003520bb
|
FS-5208 --resolve
|
2013-05-15 07:37:12 -05:00 |
|
Anthony Minessale
|
793008a215
|
FS-5011 try to fill gaps
|
2013-05-14 11:23:21 -05:00 |
|
Anthony Minessale
|
ec7d8a0118
|
FS-5416 --resolve just missing the part that registers it
|
2013-05-14 07:38:20 -05:00 |
|
Anthony Minessale
|
fcb699c8b7
|
FS-5407 --resolve
|
2013-05-13 14:21:25 -05:00 |
|
Anthony Minessale
|
e8ecb64666
|
FS-5410 --resolve
|
2013-05-13 13:15:54 -05:00 |
|
Raymond Chandler
|
d125147dd8
|
add context
|
2013-05-10 16:32:22 -04:00 |
|
Anthony Minessale
|
d6c2b9a2fb
|
FS-5085 the last change helped weed out the real bug which is this commit
|
2013-05-10 10:45:07 -05:00 |
|
Anthony Minessale
|
e5754ab3ee
|
FS-5403 --resolve
|
2013-05-10 09:59:19 -05:00 |
|
Anthony Minessale
|
e44c278c68
|
move log message to avoid logging null
|
2013-05-09 14:35:19 -05:00 |
|
Anthony Minessale
|
3fc8f7888a
|
FS-5399 --resolve
|
2013-05-09 14:09:23 -05:00 |
|
Anthony Minessale
|
3847ae028a
|
FS-5360 --resolve fields are exec-on-max-failures exec-on-max-timeouts pin, needs testing
|
2013-05-09 12:29:04 -05:00 |
|
Anthony Minessale
|
a08965601c
|
FS-5390 --resolve
|
2013-05-09 10:30:00 -05:00 |
|
Anthony Minessale
|
646b34a2a2
|
FS-5398
|
2013-05-09 10:10:06 -05:00 |
|
William King
|
569da261aa
|
FS-5395: False alarm on a reported valgrind memory leak. The io_private is alloc'd from a memory pool which valgrind sucks at tracking. No need to free this, because it'll get cleared when the memory pool on the rsession is destroyed.
|
2013-05-08 18:45:55 -07:00 |
|
William King
|
924e24a0de
|
FS-5395: --resolve Resolve another mod_rtmp crash where oh specific hangup scenarios there would be a free of variable that wasn't ever malloced
|
2013-05-08 16:53:15 -07:00 |
|
Anthony Minessale
|
2e19cbcc61
|
FS-5085 I discovered that the bowout is happening from both legs at once, we only need to check this condition on the A side of the loopback bridge
|
2013-05-08 13:17:45 -05:00 |
Brian West
|
7c8c758586
|
Undo previous change
|
2013-05-08 14:40:48 -05:00 |
|
Raymond Chandler
|
3c132c91b3
|
FS-5288 --resolve
|
2013-05-08 13:58:43 -04:00 |
|
Raymond Chandler
|
5f0d33338e
|
FS-5327 --resolve
|
2013-05-08 13:58:17 -04:00 |
|
Anthony Minessale
|
900b0c1747
|
FS-5371 --resolve typo
|
2013-05-08 09:19:05 -05:00 |
|
William King
|
f4bde33dab
|
Revert "fixed stuck mod_rtmp session when the call is killed from fs side, such as using uuid_kill"
This reverts commit d8edc031fa.
Conflicts:
src/mod/endpoints/mod_rtmp/mod_rtmp.c
|
2013-05-07 16:08:15 -07:00 |
|
Anthony Minessale
|
2b950b9599
|
FS-5168 --resolve
|
2013-05-07 14:10:03 -05:00 |
|
Anthony Minessale
|
bf3f26b0f8
|
FS-5383 --resolve
|
2013-05-07 08:31:48 -05:00 |
Ken Rice
|
c7567d418e
|
fix mod_spandsp on systems with libjbig
|
2013-05-06 18:27:20 -05:00 |
Michael Jerris
|
99fd7a87ff
|
fix auto in will not use the last slot
|
2013-05-06 11:45:30 -04:00 |
|
Anthony Minessale
|
65f0d16dee
|
FS-5371 --resolve
|
2013-05-03 13:38:44 -05:00 |
|
Anthony Minessale
|
749afaa7a3
|
FS-5365 --resolve
|
2013-05-03 13:13:44 -05:00 |
|
Michael Jerris
|
3d934ad397
|
add bgsystem for background system calls
|
2013-05-03 16:23:35 -04:00 |
|
Anthony Minessale
|
766db71ecd
|
FS-5085 adding this patch but still wondering what causes this issue
|
2013-05-03 12:30:57 -05:00 |
|
Anthony Minessale
|
a062444b4c
|
dress up event fired after parsing a message
|
2013-05-03 11:43:01 -05:00 |
|
William King
|
ec0067b04c
|
FS-5240: --resolve Please test
|
2013-05-03 00:54:58 -05:00 |
|
Anthony Minessale
|
a30989d769
|
prevent t38_passthru and fax_detect from both happening at once
|
2013-05-02 22:22:59 -05:00 |
|
William King
|
2e7c219b7e
|
FS-4332: --resolve
|
2013-05-03 00:02:05 -05:00 |
|
Anthony Minessale
|
d0e2e9ae9c
|
FS-4875 auto setting ignore_early_media causes unwanted side effects for others, it will have to be supplied by the user
|
2013-05-02 21:22:16 -05:00 |
|
Anthony Minessale
|
95d31525ce
|
FS-5359 --resolve
|
2013-04-30 18:46:15 -05:00 |
|
Brian West
|
91712b5774
|
add channel data to this event
|
2013-04-30 14:44:15 -05:00 |
|
Brian West
|
52f867b142
|
fix stop the correct way
|
2013-04-30 13:25:15 -05:00 |
|
Anthony Minessale
|
91f8c53568
|
add uuid of orig picked channel too
|
2013-04-30 11:58:10 -05:00 |
|
Anthony Minessale
|
99e91acc5f
|
add execute_on_pickup and api_on_pickup
|
2013-04-30 11:41:47 -05:00 |
|
Brian West
|
85957b9557
|
fix stopping of streams
|
2013-04-30 12:33:25 -05:00 |
|
Anthony Minessale
|
a9587acac2
|
FS-5358 --resolve use allow-transcoding=true param in global settings or fifo_allow_transcoding=true channel var on per caller basis
Conflicts:
src/mod/applications/mod_fifo/mod_fifo.c
|
2013-04-30 09:42:11 -05:00 |
|
Anthony Minessale
|
89afd89741
|
FS-5286 we can try this for added protection
|
2013-04-29 09:20:19 -05:00 |
|
Anthony Minessale
|
e23d4d37aa
|
FS-5355 --resolve
|
2013-04-29 08:51:30 -05:00 |
|
Anthony Minessale
|
e495702e7d
|
FS-4990 --resolve
|
2013-04-26 17:23:30 -05:00 |
|
Brian West
|
49b999c167
|
FS-5316 --resolve
|
2013-04-25 13:48:56 -05:00 |
|
Brian West
|
115061a4da
|
Add application layer keepalive options to sofia and expose config options
Conflicts:
src/mod/endpoints/mod_sofia/mod_sofia.h
|
2013-04-25 12:19:20 -05:00 |
|
Anthony Minessale
|
66bfd299f5
|
FS-5346 --resolve use new originate_delay_start=<ms> to get this
|
2013-04-24 15:08:08 -05:00 |
|
Anthony Minessale
|
e852ef6411
|
FS-5344 --resolve
|
2013-04-24 12:24:05 -05:00 |
|
Anthony Minessale
|
c4c2883c61
|
FS-5331
|
2013-04-24 11:33:18 -05:00 |
|
William King
|
198ae2fa05
|
If the rsession is null, then don't try to unlock it, since that'll just result in a segfault.
|
2013-04-23 17:48:07 -07:00 |
|
William King
|
985c8de056
|
fixed rtmp active calls count
|
2013-04-23 17:48:07 -07:00 |
|
William King
|
7df4e52d61
|
added rsession check before comparing its state. commented out active sessions loop
|
2013-04-23 17:48:07 -07:00 |