Commit Graph

272 Commits

Author SHA1 Message Date
Anthony Minessale 79ebcb104b add enable-chat sofia profile param which defaults to true when not present, set to false to turn off the chat interface in sofia 2014-04-19 12:29:10 -05:00
Travis Cross b72194b72b Move loop exit conditionals
The net effect here is the code looks more "regular" and reads more
linearly.
2014-04-09 18:41:03 +00:00
Travis Cross 4a8dace5ab Avoid considering more phrase actions after break
Previously we would continue considering phrase actions even after
receiving a break action; we would only break on the next input
clause.  It appears the intent here was to break before the next
action.
2014-04-09 18:41:02 +00:00
Travis Cross 75b8f3e0a8 Improve comment 2014-04-09 18:41:02 +00:00
Travis Cross ffc3f9bb0b Consolidate two conditionals
If we get SWITCH_STATUS_BREAK then we didn't get
SWITCH_STATUS_SUCCESS.
2014-04-09 18:41:02 +00:00
Travis Cross 549aba0d2f Remove variable assignment without effect
We're breaking out of the loop here anyway, so setting done to true is
useless.
2014-04-09 18:41:02 +00:00
Travis Cross 2ace7bc79b Fix memory leak in phrase macro playback
We were leaking memory when break_on_match was set or when we received
back SWITCH_STATUS_BREAK from a callee as we were failing to free
field_expanded_alloc.
2014-04-09 18:41:02 +00:00
Travis Cross f83d6770ff Remove tautological conditional
If pattern is null we're setting it to a non-null value, so this
branch will always be taken.

Use `git diff -w` or `git log -p -w` to see what's going on in this
commit.
2014-04-09 18:41:02 +00:00
Travis Cross 1a71cf886e Fix memory leak on memory error
In the event of a memory error, we were trying to free a null pointer
while leaking the allocation for field_expanded_alloc.
2014-04-09 18:41:02 +00:00
Travis Cross a0b8d92219 Move variables down into loop where they're used
These variables aren't used outside of this for loop, so they should
be declared within it.
2014-04-09 18:41:01 +00:00
Travis Cross 2d811e0ba0 Suppress spurious warning in phrase macro playback
Prior to this commit, if anything at all went wrong in
switch_ivr_phrase_macro_event() we would generate a warning like this:

  [WARNING] switch_ivr_play_say.c:348 Macro [macro_name]: 'pattern_name' did not match any patterns

This is clearly misleading.  The natural thing to do on seeing that
message is to verify that the language files are there, and that the
pattern really does exist in that macro.  But none of that was usually
the problem.  The message would be generated if the language wasn't
found, or if the channel had gone away, for example.

With this commit, we verify that we actually tried looking for the
pattern before displaying the warning about the pattern not matching.
2014-04-09 04:48:09 +00:00
Ken Rice 6e7d5d0897 update copyright header for 2014 2014-02-12 12:08:56 -06:00
Peter Olsson 084e245085 Lots of trivial tweaks to minimize compiler warnings, especially on 64-bit platform: Added missing type casts, changed types, added missing NULL checks. 2014-01-22 22:30:23 +01:00
Anthony Minessale a27fe4c5a5 some null checks from coverity 2013-12-26 23:57:10 +05:00
Anthony Minessale ea6a05cac5 FS-6033 --resolve 2013-12-10 03:42:18 +05:00
Raymond Chandler beb0673f25 expose useful internals... thanks jaybinks 2013-11-26 19:48:49 -05:00
Anthony Minessale 00f52f3002 FS-4965 calling the variable playback_last_offset_pos instead 2013-11-25 16:09:12 -06:00
Anthony Minessale 3c83138bb4 FS-5807 contd 2013-09-20 12:41:16 -05:00
Anthony Minessale 75da9d1e73 FS-5807 --resolve 2013-09-20 10:47:39 -05:00
Ken Rice 41880353f9 FS-5589 --resolve 2013-07-10 09:44:02 -05:00
Anthony Minessale 8bcff4ca4d fix input event checker pre-empting return value from dtmf checker when both are present 2013-07-01 14:31:43 -05:00
Nathan Neulinger 32adc789f6 make noexpandtab explicit in all vim modelines other than xml files 2013-06-25 11:50:17 -05:00
Anthony Minessale 8ac3178e45 FS-5242 2013-05-21 10:03:22 -05:00
Anthony Minessale d012c5f392 omg it can make calls ... long way to go ... 2013-03-31 21:27:15 -05:00
Anthony Minessale e976144ef1 FS-5216 seems like invalid codec lets try this 2013-03-29 22:35:32 -05:00
Anthony Minessale c0f736c9da FS-5242 2013-03-29 10:54:45 -05:00
Anthony Minessale bf93eb47e9 FS-5131 --resolve indeed, nice catch 2013-02-28 09:28:00 -06:00
Anthony Minessale aa89eab58f FS-4709 --resolve, not adding the change to switch_rtp I want to have that log line there, don't make vanity changes mixed in with code changes 2013-02-26 11:49:17 -06:00
Anthony Minessale 042347802b changing the params thing a bit, use {foo=bar} syntax instead 2013-02-20 16:34:22 -06:00
Marc Olivier Chouinard 0bfddcfd0f Phrases: Allow phrase with no pattern to be processed 2013-01-22 22:14:58 -05:00
Marc Olivier Chouinard af6ae011c7 FS-3743 --comment-only I've added the variable playback_timeout_as_success so you can make it return success even if it timed out. 2013-01-13 01:18:44 -05:00
Anthony Minessale d3fcfa8245 FS-4273 --resolve 2012-12-20 11:44:21 -06:00
Anthony Minessale 8be9d429fb fix recursion error 2012-12-10 10:56:07 -06:00
Michael Jerris 195949f25f don't seg on no valid_terminators 2012-07-02 11:55:49 -04:00
Anthony Minessale ed6e7b9fc0 if valid_terminators string starts with = it implies one of them must be typed 2012-06-28 13:17:57 -05:00
Anthony Minessale 8bb55ed4bf abstract out originate_signal_bond to a function to avoid confustion and regressions 2012-05-29 13:10:15 -05:00
Anthony Minessale ae23edad9c FS-4111 --resolve 2012-04-18 14:49:00 -05:00
Ken Rice c5554eb939 Copyright date update. 2012-04-18 11:52:02 -05:00
Anthony Minessale 2f998764c8 FS-4101 --resolve 2012-04-11 08:39:01 -05:00
Anthony Minessale 845330eefa FS-3399 --resolve 2012-04-05 13:15:45 -05:00
Anthony Minessale a4320da5a8 fix regression from earlier today 2012-01-05 16:01:27 -06:00
Anthony Minessale e185ff0075 allow dmachine and input callback to co-exist 2012-01-05 09:39:18 -06:00
Anthony Minessale 2f786a07e9 lower token freq to 5, put it in a define and have more obvious warning about full lots 2011-10-26 12:57:59 -05:00
Anthony Minessale 5fe3a22d83 fix inaccurate sample count in file handle, buffered samples were being double tallied 2011-09-21 11:05:33 -05:00
Michael S Collins e4d473190d mod_dptools: add transfer_on_failure ext/dp/context to play_and_get_digits
If max tries is reach and user has not made a valid entry then system transfers the call leg to the specified destination.
2011-08-18 20:29:52 -07:00
Anthony Minessale 5cf6dc3115 FS-3505 --resolve copied same code from the other place the original intention was to behave as described in the bug report but it seemed like a reasonable enough request 2011-08-16 16:11:38 -05:00
Anthony Minessale 38b3f43d7d add prefix chars to playback_terminators + means include the term in the string and x means include the char and return SWITCH_STATUS_RESTART eg #+* only includes the * if you type it but not the # 2011-05-19 15:39:43 -05:00
Anthony Minessale 73279f01bf FS-3166 --resolve 2011-04-22 16:43:29 -05:00
Marc Olivier Chouinard 4137b360cf switch_ivr/xml: Change the structure of the phrases/language system. Previously it was fxml->phrases->macros->language->macro. Changed it so fxml->languages->language->phrases->macros->macro
You can have sub macros <macros name="voicemail"><macro ...> and allow you to call it login@voicemail.
Change the sound-path to sound-prefix to make it constistant with the rest of freeswitch.
Also allow to set a sound-prefix to a macros, so you can override it for a specific file set.
You can set say-modules="en" or whatever in the <language section to define that say module to use.
2011-04-20 13:09:03 -04:00
Daniel Swarbrick 8c98328433 Allow longer input regexes to be used in phrases 2011-04-06 15:36:35 +02:00