9ace496fe3
full_contact must be freed by sofia. There isn't a chance of this having blown anything up, but Coverity is right that this should be initialized with NULL to be safe against future refactors.
2013-05-18 19:13:18 -07:00
ef1bf8e34a
Was causing a very small leak on naptr lookups. Upon review just happened to be a typo missing a bang.
2013-05-18 17:50:50 -07:00
508fb78e94
My bad. some how a make didn't catch this issue after a cleanup refactor. In this instance buf is being treated as an 8 byte number, not a pointer.
2013-05-18 17:46:13 -07:00
291244c099
Coverity reported an Uninitialized pointer read. Upon further digging it appears that there is a code path where incoming packets can come in out of order, so this section of code tries to see if it can find the missed packets. As per FS-5202 there is a case where under heavy load the packet exists, and has most of the packet parsed, but still has a NULL pointer for the packet buffer. These two lines would at least help detect the edge case.
2013-05-18 17:34:16 -07:00
45803e38e7
Edge case for when you are subscribing to presence on a valet parking lot. In which case there would be a small leak.
2013-05-18 17:06:54 -07:00
d27a95a50e
Possible leak if someone were to try and add extra headers to a channel that had either an inbound info on that session or the session were to be deflected. I don't see a way that these extra headers could be added outside of a C module subscribing to the session states, but just to make sure I'm adding these so that just like other extra header locations it's cleaned up.
2013-05-18 17:00:41 -07:00
f718a0572f
Alice meet rabit hole. There is a leak here on every invite that comes back from a status 180 when the other side is not FS, but you have presence enabled. Thanks to Coverity scan for location this condition. This 'might' not have been leaking if sofia was automatically freeing this when the sofia object was destroyed, but all other locations where sip_header_as_string where called they were all followed by a su_free, so I assume not.
2013-05-18 16:35:03 -07:00
f519ad195a
If the mod_sofia global presense hash is null, then make sure to free the matches variable before going to done.
2013-05-18 16:05:40 -07:00
09553f424a
FS-5443: --resolve leaked because the JS api's copy and return new malloc'd pointers.
2013-05-18 15:47:01 -07:00
7f3f4855a6
When message events were added, the debug field name was overlooked. This would have only been hit when debug level was above 'DEBUG1' and at that point it would have incorrectly chosen debug display names.
2013-05-18 15:10:44 -07:00
4fcefab0d0
Minor typo. User is being passed into this fuction as a long pointer, not a long.
2013-05-18 14:29:59 -07:00
047dc67098
read() does not NULL terminate statbuf, but strstr expects statbuf to be null terminated.
2013-05-18 14:26:40 -07:00
3f06bbd04a
This was writing a null one space to the right, outside of the malloc'd buffer. On further review this uses apr_vsnprintf which always returns null terminated.
2013-05-18 13:38:24 -07:00
de0fea316e
FS-5434 --resolve
2013-05-17 21:38:32 -05:00
2bafe135c0
remove flag
2013-05-17 16:13:19 -05:00
e03b6d0878
fix silence_stream size bug
2013-05-17 16:11:04 -05:00
ea881b191f
media/srtp refactoring pass
2013-05-17 15:39:30 -05:00
8d7aa3ff65
FS-5441: --resolve
2013-05-17 12:39:17 -07:00
58e205ccdb
how...?
2013-05-17 11:36:31 -07:00
cfeb6aaf54
Since there isn't neutral ground, on the rtmp state callback we actually have to force the write lock of the session, but we only need a try lock on removing the session from the rsession->session_hash. This removes a deadlock caused when we had to enforce with locks that the rsession couldn't be destroyed if the FS session was in the middle of a hangup.
2013-05-17 11:36:30 -07:00
f24d1cde3d
Seems the session wasn't coming to the hangup in a locked state.
2013-05-17 11:36:30 -07:00
36f198e883
Seems having a read lock still prevents a write lock to be taken, even if the thread that is trying to get the write lock currently has the read lock.
2013-05-17 11:36:29 -07:00
9b0212ab59
Include the write lock since we're changing the tech_pvt
2013-05-17 11:36:29 -07:00
37d109b107
Some tweaks to the image translate code
2013-05-16 02:28:20 +08:00
97faaab42c
FS-5430 --resolve
2013-05-15 09:27:18 -05:00
a4f3629773
trivial fix compiler warning
2013-05-15 11:51:55 -05:00
d50366f377
FS-5418 --resolve
2013-05-15 08:08:41 -05:00
d5ad021720
FS-5208 --resolve
2013-05-15 07:36:56 -05:00
644720454f
fix some minor regression in media code
2013-05-14 12:55:02 -05:00
101b116daf
FS-5011 try to fill gaps
2013-05-14 11:22:53 -05:00
11f8491170
Fixed a silly in the FAX image resolution settings
2013-05-15 01:49:58 +08:00
75c3b8b83e
FS-5325 force rebuild
2013-05-14 07:44:34 -05:00
81788f1192
FS-5416 --resolve just missing the part that registers it
2013-05-14 07:38:00 -05:00
0aaba4588a
fix stun lookup returning 1 for port
2013-05-13 16:17:19 -05:00
97d47af882
FS-5407 --resolve
2013-05-13 14:21:08 -05:00
1eae2a1941
FS-5410 --resolve
2013-05-13 13:15:33 -05:00
fd86c038c9
FS-5406 --resolve
2013-05-12 08:06:31 -05:00
d466316ace
FS-5325 windows compile
2013-05-10 17:31:01 -05:00
15f219ea25
Require OpenSSL
2013-05-10 16:02:15 -05:00
bba4540fe5
add context
2013-05-10 16:31:12 -04:00
5761624f5a
FS-5325
2013-05-10 12:55:26 -05:00
cb7a6bd34b
FS-5085 the last change helped weed out the real bug which is this commit
2013-05-10 10:45:28 -05:00
b85c24df08
spandsp windows fix syntax for gettimeofday
2013-05-10 12:46:03 -05:00
bb6b02f2d6
FS-5403 --resolve
2013-05-10 09:59:02 -05:00
39fb4544dd
FreeTDM: ftmod_misdn uses clock_gettime() which is in librt, add a check
...
Fixes -Wl,-z,now / -Wl,-z,defs errors about undefined symbols.
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-10 19:04:10 +02:00
80a2b76620
FreeTDM: Make libpri pri_version() check -Wunused-but-set-variable safe
...
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-10 19:04:10 +02:00
284ce5407b
FreeTDM: Move external ftmod_* library dependencies to _LIBADD
...
Making the build -Wl,--as-needed safe.
Tested on Centos 5.x + Gentoo.
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-10 19:04:10 +02:00
b793ccbe43
FreeTDM: Fix implicit conversion between enumeration types error
...
Full clang error message:
error: implicit conversion from enumeration type 'ftdm_bool_t' to
different enumeration type 'ftdm_status_t' [-Werror,-Wconversion]
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-10 19:04:10 +02:00
cbf22d8a32
FreeTDM: Silence -Wtautological-compare warnings emitted by clang
...
Fixes "warning: comparison of unsigned expression >= 0 is always true".
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-10 19:04:09 +02:00
ae58a4c1ba
FreeTDM: Use ftdm_unused_arg() to silence -Wunused-argument warnings
...
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
2013-05-10 19:04:09 +02:00
William King
Jeff Lenk
Anthony Minessale
Steve Underwood
Ken Rice
Raymond Chandler
Stefan Knoblich