4d08e07237
Fixed a weakness in error UDPTL lost packet recovery. Hopefully this addresses
...
FS5202.
2013-05-31 09:04:46 -05:00
b90dee2461
Swap this
2013-05-31 09:16:50 -05:00
e1a773406d
Unsigned values are never less than zero
2013-05-29 03:02:21 +00:00
1637a08206
Avoid using psession uninitialized in mod_fsk
2013-05-29 03:00:13 +00:00
04b8de0619
Avoid using memory after we free it
...
Without setting errmsg to NULL here, we'll try to print this freed
value again below if another error doesn't intercede.
2013-05-29 02:52:23 +00:00
5e7485ff20
Avoid dereferencing potential null value
2013-05-29 02:52:13 +00:00
9ce4be3daa
Remove assignment without effect
2013-05-29 02:52:05 +00:00
ca9d806042
Avoid dereferencing potential null value
2013-05-29 02:51:57 +00:00
83e33bb399
Handle potential malloc failure better
2013-05-29 02:51:51 +00:00
58e48416be
Add missing text editor local variable blocks
2013-05-29 02:50:03 +00:00
00769c458f
Fix unlikely memory leak in ESL
2013-05-29 02:48:59 +00:00
800fe2a970
Remove assignment without effect in fs_cli
2013-05-29 02:48:50 +00:00
987f76d379
Avoid dangling reference at end of fs_cli
...
Not that it really matters since we're returning to the OS momentarily
at that point anyway.
2013-05-29 02:48:33 +00:00
de3727fe06
Add common include paths for jni.h and jni_md.h
2013-05-29 02:48:28 +00:00
73257d7ca2
FS-5479 --resolve
2013-05-29 02:48:23 +00:00
1926a54bd0
fix unused parameter warning on windows
2013-05-29 02:48:17 +00:00
50a02efd27
Fix variable type in mod_nibblebill
2013-05-29 02:48:11 +00:00
e964215868
Work around error in pocketsphinx-0.7
...
fsg_search.c:263:2: error: non-void function 'fsg_search_reinit' should return a value [-Wreturn-type]
2013-05-29 02:48:01 +00:00
d5d9e45632
Remove self-assignment without any effect
...
clang:
error: explicitly assigning a variable of type 'uint16_t' (aka 'unsigned short') to itself [-Werror,-Wself-assign]
2013-05-29 02:47:41 +00:00
e60877cde6
Add missing newline at end of mod_say_fa.c
2013-05-29 02:47:08 +00:00
cd549aa44a
FS-5157 patch accepted
2013-05-29 00:22:19 +02:00
2cac71675f
log auto adjust ip and port separate so it doesn't get clobbered on hold/update events
2013-05-28 16:26:05 -05:00
4d5ea55924
FS-5480 --resolve
2013-05-28 08:18:00 -05:00
acc8eb5cb6
Remove unused variable in mod_rtmp
...
Unused variables break the build with recent versions of gcc and
clang.
2013-05-26 05:29:21 +00:00
aea5cdd989
Add commit note about shell escaping
...
Disregard the supplemental commit text on
commit a744b202fd
2013-05-26 05:28:51 +00:00
a744b202fd
Quote arguments to shell when sending email
...
Note that the function switch_util_quote_shell_arg is implemented
incorrectly for unix shells, so this is still not safe until that
function is fixed.
Reported-by: Nathan Neulinger <nneul@mst.edu>
FS-5450 --resolve
2013-05-26 01:41:02 +00:00
ff85c6cfdf
Fix memory leaks in mod_tts_commandline
...
We were using both switch_util_quote_shell_arg and
switch_string_replace without freeing the results even though both
functions malloc.
2013-05-26 01:08:10 +00:00
103d97e208
Leave room for switch_escape_string to add a terminating null
...
Thanks-to: Nathan Neulinger <nneul@mst.edu>
FS-5448 --resolve
2013-05-25 23:29:48 +00:00
2870bb9200
Fix comment spelling
...
Thanks-to: Mariusz Czułada <manieq.net@gmail.com>
2013-05-25 21:47:08 +00:00
ed276a10d2
Fix memory corruption in mod_erlang_event
...
Thanks-to: Alexandre Snarskii <snar@snar.spb.ru>
FS-5465 --resolve
2013-05-25 21:46:58 +00:00
4b2dd0a8d9
Don't setup ZRTP without a session and channel
...
FS-5472 --resolve
2013-05-25 21:46:11 +00:00
f07e58d30f
Handle a failure of strerror_r
...
This fixes the build on gcc-4.7.3. The build was breaking with:
error: ignoring return value of 'strerror_r', declared with attribute warn_unused_result [-Werror=unused-result]
2013-05-25 21:44:16 +00:00
6c4ec9d954
Fix a possible deadlock scenario in the impossible scenario from the last patch.
2013-05-25 11:07:30 -07:00
a6d24d8eac
Redundant code. The if/else block makes more sense than the equivalent in two separate if's.
2013-05-25 07:46:47 -07:00
782480c48b
Better to not pass tmp_socket to setsockopt if there was an error here creating the socket.
2013-05-25 07:36:43 -07:00
479a06bda6
It's been missing a break there for ~4 years and instead using the 8k max_ms values(the ptime_div value is the same).
2013-05-25 07:16:51 -07:00
a4b8226c89
Cleaning up logically dead code.
2013-05-25 07:02:33 -07:00
e5ca2a0028
This condition should NEVER be hit, but in case the started thread is unable to locate itself in the EVENT_DISOATCH_QUEUE_THREADS array, it's best to return null here and kill the unexpected event thread rather than segfault FS by writing outside of the bounds of the EVENT_DISPATCH_QUEUE_RUNNING array.
2013-05-25 06:51:22 -07:00
50b664c2dd
Small off by one error. If the array is of size 144, then an index of 144 inclusive is an error.
2013-05-25 06:41:22 -07:00
dfbc175776
Let's bit a bit safer when dereferencing pointers.
2013-05-24 20:03:19 -07:00
6c3062a768
Removing logically dead code
2013-05-24 19:59:20 -07:00
4edf66be98
If there is a problem reading the dictionary file, don't leak memory...
2013-05-24 19:55:37 -07:00
8803804f90
Removing unused code
2013-05-24 19:53:10 -07:00
47c6981a9f
More explicit and defensive code so if the init fails we know we handling this pointer safely, because rc_config_init will free the pointer if there was a problem, but it will not set the pointer to NULL.
2013-05-24 19:49:20 -07:00
6320042f6b
Another location where mod_rtmp would leak memory.
2013-05-24 19:45:24 -07:00
83ae82fd2d
Fix improper handling of a double linked list that could have caused a memory leak.
2013-05-24 19:42:02 -07:00
b3aea78730
Appears to have been a copy paste error because this doesn't do what the api claims, and it also leaks the reference to the new node.
2013-05-24 19:35:43 -07:00
8a743cb2f3
Fixing a memory leak. name needs to be freed since it's being strdup'd lower.
2013-05-24 19:31:40 -07:00
aecd186ba5
FS-5470 --resolve
2013-05-24 09:37:40 -05:00
dc13cb847f
FS-5466 --resolve
2013-05-24 09:14:26 -05:00
Steve Underwood
Brian West
Travis Cross
Jeff Lenk
Mariusz Czułada
Anthony Minessale
William King