14755 Commits

Author SHA1 Message Date
Nathan Neulinger
fffe3d06aa Allow skinny speed dials to work when already off-hook 2013-05-30 12:15:20 -05:00
Jeff Lenk
24c13adfaf FS-5483 --resolve 2013-05-29 09:32:24 -05:00
Travis Cross
a82878f786 Unsigned values are never less than zero 2013-05-29 03:02:07 +00:00
Travis Cross
f07181e266 Avoid using psession uninitialized in mod_fsk 2013-05-29 02:59:05 +00:00
Steve Underwood
3519e0f4c3 More tweaks towards colour FAXing 2013-05-29 10:07:08 +08:00
Steve Underwood
3b595efc60 More tweaks towards colour FAXing 2013-05-29 09:53:56 +08:00
Mariusz Czułada
d0af6ce81d FS-5157 patch accepted 2013-05-29 00:19:49 +02:00
Brian West
ecd8aabf5d log auto adjust ip and port separate so it doesn't get clobbered on hold/update events 2013-05-28 16:25:39 -05:00
Anthony Minessale
9d8af739c8 FS-5480 --resolve 2013-05-28 08:17:44 -05:00
Travis Cross
3c8db7c715 Avoid using memory after we free it
Without setting errmsg to NULL here, we'll try to print this freed
value again below if another error doesn't intercede.
2013-05-28 05:28:19 +00:00
Travis Cross
5b1d1de1a7 Add common include paths for jni.h and jni_md.h 2013-05-27 16:19:24 +00:00
Travis Cross
f3541e00f4 Fix variable type in mod_nibblebill 2013-05-27 07:58:33 +00:00
Travis Cross
25d488a801 Work around error in pocketsphinx-0.7
fsg_search.c:263:2: error: non-void function 'fsg_search_reinit' should return a value [-Wreturn-type]
2013-05-27 07:40:00 +00:00
Travis Cross
076a7706db Remove extraneous parentheses in mod_say_pl 2013-05-26 12:22:51 +00:00
Travis Cross
c9b3909ac1 Add missing newline at end of mod_say_fa.c 2013-05-26 12:22:08 +00:00
Travis Cross
4ea2ae5d38 Remove extraneous parentheses
This resolves a clang warning:

  error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
2013-05-26 12:19:19 +00:00
Travis Cross
065043ce67 Remove unused variable in mod_rtmp
Unused variables break the build with recent versions of gcc and
clang.
2013-05-26 04:53:16 +00:00
Travis Cross
04c3b913aa Quote arguments to shell when sending email
Note that the function switch_util_quote_shell_arg is implemented
incorrectly for unix shells, so this is still not safe until that
function is fixed.

Reported-by: Nathan Neulinger <nneul@mst.edu>

FS-5450 --resolve
2013-05-26 01:27:16 +00:00
Travis Cross
8f10ff073a Fix memory leaks in mod_tts_commandline
We were using both switch_util_quote_shell_arg and
switch_string_replace without freeing the results even though both
functions malloc.
2013-05-26 01:03:08 +00:00
Travis Cross
3dd2376475 Leave room for switch_escape_string to add a terminating null
Thanks-to: Nathan Neulinger <nneul@mst.edu>

FS-5448 --resolve
2013-05-25 23:28:55 +00:00
Travis Cross
ab641842f4 Fix comment spelling
Thanks-to: Mariusz Czułada <manieq.net@gmail.com>
2013-05-25 21:40:40 +00:00
Travis Cross
c09a261d58 Fix memory corruption in mod_erlang_event
Thanks-to: Alexandre Snarskii <snar@snar.spb.ru>

FS-5465 --resolve
2013-05-25 21:20:41 +00:00
Travis Cross
012003b5ff Don't setup ZRTP without a session and channel
FS-5472 --resolve
2013-05-25 21:10:11 +00:00
William King
db0d03532d Fix a possible deadlock scenario in the impossible scenario from the last patch. 2013-05-25 11:06:01 -07:00
William King
7be8184b2a Redundant code. The if/else block makes more sense than the equivalent in two separate if's. 2013-05-25 07:47:09 -07:00
William King
938699d0b6 Better to not pass tmp_socket to setsockopt if there was an error here creating the socket. 2013-05-25 07:37:28 -07:00
William King
7d531c0966 It's been missing a break there for ~4 years and instead using the 8k max_ms values(the ptime_div value is the same). 2013-05-25 07:15:49 -07:00
William King
f04842d4c8 Cleaning up logically dead code. 2013-05-25 07:02:49 -07:00
William King
acf9a72e3f This condition should NEVER be hit, but in case the started thread is unable to locate itself in the EVENT_DISOATCH_QUEUE_THREADS array, it's best to return null here and kill the unexpected event thread rather than segfault FS by writing outside of the bounds of the EVENT_DISPATCH_QUEUE_RUNNING array. 2013-05-25 06:51:37 -07:00
William King
5d939b9652 Small off by one error. If the array is of size 144, then an index of 144 inclusive is an error. 2013-05-25 06:41:03 -07:00
William King
12f2f674f9 Let's bit a bit safer when dereferencing pointers. 2013-05-24 20:24:04 -07:00
William King
480407e5f3 Removing logically dead code 2013-05-24 19:59:32 -07:00
William King
9ea90341f7 If there is a problem reading the dictionary file, don't leak memory... 2013-05-24 19:55:50 -07:00
William King
2e6d3a1f2a Removing unused code 2013-05-24 19:53:26 -07:00
William King
b42ee84933 More explicit and defensive code so if the init fails we know we handling this pointer safely, because rc_config_init will free the pointer if there was a problem, but it will not set the pointer to NULL. 2013-05-24 19:49:33 -07:00
William King
dc4209275d Another location where mod_rtmp would leak memory. 2013-05-24 19:45:38 -07:00
William King
194e1ae366 Fix improper handling of a double linked list that could have caused a memory leak. 2013-05-24 19:42:17 -07:00
William King
e2d6bc3340 Appears to have been a copy paste error because this doesn't do what the api claims, and it also leaks the reference to the new node. 2013-05-24 19:35:56 -07:00
William King
f3fd94b3e5 Fixing a memory leak. name needs to be freed since it's being strdup'd lower. 2013-05-24 19:31:26 -07:00
Anthony Minessale
4bf4b2c408 FS-5470 --resolve 2013-05-24 09:37:25 -05:00
Anthony Minessale
f42fffb65f FS-5466 --resolve 2013-05-24 09:14:13 -05:00
Anthony Minessale
7f3c160793 FS-5453 --resolve 2013-05-24 08:13:41 -05:00
Mariusz Czułada
3866a6e15c FS-5042 changed event body creation 2013-05-24 12:18:00 +02:00
Raymond Chandler
610718fdff FS-4871: reduce logging a bit 2013-05-23 20:51:25 -04:00
Anthony Minessale
e02992bc6c FS-5453 --resolve this is a different issue, we just have to hangup the loopback channel so the loopback and the sip don't both execute the extension 2013-05-23 09:59:00 -05:00
Anthony Minessale
e169212319 swig 2013-05-23 09:53:50 -05:00
Anthony Minessale
606e197ac6 FS-5042 --resolve 2013-05-23 08:07:10 -05:00
Anthony Minessale
1b1bdf6816 FS-5453 --resolve 2013-05-23 08:00:03 -05:00
Nathan Neulinger
514fc941c0 FS-5431: --resolve fix socket creation loop for mod_skinny to avoid segfault 2013-05-23 08:13:44 -05:00
William King
15f43bac09 FS-5440: don't assert on bad input rtmp data 2013-05-22 12:38:23 -07:00