mirror of
https://github.com/MichMich/MagicMirror.git
synced 2026-04-24 06:47:07 +00:00
During the server-side migration (PR #4032), the `instanceId` was built with `Date.now()`, making it unique per client reload. This approach was fine in the old browser-based architecture where reloads cleaned up everything automatically. But now the node_helper persists across reloads, so each reconnect created a new `HTTPFetcher` while the old one kept polling - silently multiplying API calls over time. The fix is simple: use `this.identifier` as the `instanceId`, which is already stable and unique per module slot. This is the same approach the Calendar module uses. On the node_helper side, when a provider already exists for the same `instanceId`, we now skip re-creation and just resend `WEATHER_INITIALIZED` so the client picks up where it left off. Fixes https://forum.magicmirror.builders/topic/20199
109 lines
3.1 KiB
JavaScript
109 lines
3.1 KiB
JavaScript
const path = require("node:path");
|
|
const NodeHelper = require("node_helper");
|
|
const Log = require("logger");
|
|
|
|
module.exports = NodeHelper.create({
|
|
providers: {},
|
|
|
|
start () {
|
|
Log.log(`Starting node helper for: ${this.name}`);
|
|
},
|
|
|
|
socketNotificationReceived (notification, payload) {
|
|
if (notification === "INIT_WEATHER") {
|
|
Log.log(`Received INIT_WEATHER for instance ${payload.instanceId}`);
|
|
this.initWeatherProvider(payload);
|
|
} else if (notification === "STOP_WEATHER") {
|
|
Log.log(`Received STOP_WEATHER for instance ${payload.instanceId}`);
|
|
this.stopWeatherProvider(payload.instanceId);
|
|
}
|
|
// FETCH_WEATHER is no longer needed - HTTPFetcher handles periodic fetching
|
|
},
|
|
|
|
/**
|
|
* Initialize a weather provider
|
|
* @param {object} config The configuration object
|
|
*/
|
|
async initWeatherProvider (config) {
|
|
const identifier = config.weatherProvider.toLowerCase();
|
|
const instanceId = config.instanceId;
|
|
|
|
Log.log(`Attempting to initialize provider ${identifier} for instance ${instanceId}`);
|
|
|
|
if (this.providers[instanceId]) {
|
|
Log.log(`Weather provider ${identifier} already initialized for instance ${instanceId}, re-sending WEATHER_INITIALIZED`);
|
|
// Client may have restarted (e.g. page reload) - re-send so it recovers location name
|
|
this.sendSocketNotification("WEATHER_INITIALIZED", {
|
|
instanceId,
|
|
locationName: this.providers[instanceId].locationName
|
|
});
|
|
return;
|
|
}
|
|
|
|
try {
|
|
// Dynamically load the provider module
|
|
const providerPath = path.join(__dirname, "providers", `${identifier}.js`);
|
|
Log.log(`Loading provider from: ${providerPath}`);
|
|
const ProviderClass = require(providerPath);
|
|
|
|
// Create provider instance
|
|
const provider = new ProviderClass(config);
|
|
|
|
// Set up callbacks before initializing
|
|
provider.setCallbacks(
|
|
(data) => {
|
|
// On data received
|
|
this.sendSocketNotification("WEATHER_DATA", {
|
|
instanceId,
|
|
type: config.type,
|
|
data
|
|
});
|
|
},
|
|
(errorInfo) => {
|
|
// On error
|
|
this.sendSocketNotification("WEATHER_ERROR", {
|
|
instanceId,
|
|
error: errorInfo.message || "Unknown error",
|
|
translationKey: errorInfo.translationKey
|
|
});
|
|
}
|
|
);
|
|
|
|
await provider.initialize();
|
|
this.providers[instanceId] = provider;
|
|
|
|
this.sendSocketNotification("WEATHER_INITIALIZED", {
|
|
instanceId,
|
|
locationName: provider.locationName
|
|
});
|
|
|
|
// Start periodic fetching
|
|
provider.start();
|
|
|
|
Log.log(`Weather provider ${identifier} initialized for instance ${instanceId}`);
|
|
} catch (error) {
|
|
Log.error(`Failed to initialize weather provider ${identifier}:`, error);
|
|
this.sendSocketNotification("WEATHER_ERROR", {
|
|
instanceId,
|
|
error: error.message
|
|
});
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Stop and cleanup a weather provider
|
|
* @param {string} instanceId The instance identifier
|
|
*/
|
|
stopWeatherProvider (instanceId) {
|
|
const provider = this.providers[instanceId];
|
|
|
|
if (provider) {
|
|
Log.log(`Stopping weather provider for instance ${instanceId}`);
|
|
provider.stop();
|
|
delete this.providers[instanceId];
|
|
} else {
|
|
Log.warn(`No provider found for instance ${instanceId}`);
|
|
}
|
|
}
|
|
});
|