mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-12-03 11:31:39 +00:00
2.3 KiB
2.3 KiB
This document describes how collaborators of this repository should work together.
Pull Requests
- never merge your own PR's
- never merge without someone having approved (approving and merging from same person is allowed)
- wait for all approvals requested (or the author decides something different in the comments)
- merge to
masteronly for releases or other urgent issues (update notification is only triggered by tags) - merges to master should be tagged with the "mastermerge" label so that the test runs through
Issues
- "real" Issues are closed if the problem is solved and the fix is released
- unrelated Issues (e.g. related to a foreign module) are closed immediately with a comment to open an issue in the module repository or to discuss this further in the forum or discord
Releases
Are done by
- @rejas
- @sdetweil
- @khassel
Pre-Deployment steps
- update dependencies (a few days before)
Deployment steps
- pull latest
developbranch - update
package.jsonandpackage-lock.jsonto reflect correct version number2.xx.0 - test
developbranch - update
CHANGELOG.md- add all contributor names:
... - add min. node version: > ⚠️ This release needs nodejs version
v20orv22, minimum version isv20.9.0
- add all contributor names:
- commit and push all changes
- after successful test run via github actions: create pull request from
developtomasterbranch- add label
mastermerge - title of the PR is
Release 2.xx.0 - description of the PR is the section of the
CHANGELOG.md
- add label
- after PR tests run without issues, merge PR
- create new release with
- corresponding version tag
v2.xx.0 - a release name:
... - description of the PR is the section of the
CHANGELOG.md
- corresponding version tag
Draft new development release
- checkout
developbranch - update
package.jsonandpackage-lock.jsonto reflect correct version number2.xx.0-develop - draft new section in
CHANGELOG.md - commit and publish
developbranch
After release
- publish release notes with link to github release on forum in new locked topic
- close all issues with label
ready (coming with next release) - release new documentation by merging
developonmasterin documentation repository