Commit Graph

28234 Commits

Author SHA1 Message Date
Joshua Colp
d1f973906a astconfigparser: Really handle case where line is simply a comment.
The regular expression would match causing the code that handled
the line if it was merely a comment to never get executed.

Change-Id: I3e4022481037ebcba9905587fe8c764b4ce21819
2016-08-03 09:49:38 -05:00
zuul
2306c71052 Merge "res_pjsip: SIP/SDP origin (o=) contained square brackets on IP6 transports." into 14 2016-08-02 15:13:19 -05:00
Kevin Harwell
9b926ac4f0 make_ari_stubs: Updated WIKI_PREFIX for 14
Change-Id: Id5678d20d8892fdcde7849c810d492527e77c15d
2016-08-02 14:26:21 -05:00
zuul
177ea926b2 Merge "menuselect: Add an opaque "member_data" string to the acceptable xml" into 14 2016-08-02 13:43:41 -05:00
Kevin Harwell
63dd0fab30 rest-api: Code out of sync with the model
Change-Id: Idccaa26fd4a423d47d013ee592b8fa6a0349c006
2016-08-02 13:04:05 -05:00
zuul
be170d0ed9 Merge "sorcery: Use more compatible regex for local expressions." into 14 2016-08-02 11:28:19 -05:00
zuul
342a2e53b7 Merge "pjproject: fixed a few bugs" into 14 2016-08-02 10:50:47 -05:00
Joshua Colp
b63262e7bf sorcery: Use more compatible regex for local expressions.
This changes the use of an empty regex for both res_sorcery_config
and res_sorcery_memory to "." instead. This is a more compatible
regular expression which also works on FreeBSD.

ASTERISK-26206 #close

Change-Id: Ia9166dd176f1597555ba22b6931180d0626c1388
2016-08-02 05:25:28 -05:00
Alexander Traud
7e0178925f res_pjsip: SIP/SDP origin (o=) contained square brackets on IP6 transports.
ASTERISK-26256 #close

Change-Id: I3fd68df561f81fdb8c6c497d465b50c12422f058
2016-08-02 03:16:10 -05:00
George Joseph
eefd446b9f menuselect: Add an opaque "member_data" string to the acceptable xml
Change-Id: Id5ac43b95c8d7395f3be37f983632169db3d1afe
2016-08-01 16:14:18 -05:00
zuul
ca721b7629 Merge "astconfigparser: Handle case where line is simply a comment." into 14 2016-08-01 15:05:09 -05:00
Joshua Colp
44b1492c83 Merge "Remove SILK payload mappings from Asterisk core." into 14 2016-08-01 14:52:27 -05:00
zuul
62c3bb566c Merge "pbx.c: Fix handling of '-' in extension name and callerid" into 14 2016-08-01 09:06:50 -05:00
Mark Michelson
d50895c7b0 Remove SILK payload mappings from Asterisk core.
SILK is a bit of a hog when it comes to using up our limited number of
dynamic payload types in the RTP engine. By freeing up four slots, it
allows for other codecs to potentially take the place.

Now, codec_silk.so will dynamically use the payload slots in the RTP
engine when it loads.

A better fix would be make RTP dynamic payload types actually
dynamic. However, at this stage of Asterisk 14 development, this is a
risky move that would be imprudent.

Change-Id: I5774e09408f9a203db189529eabdc0d3f4c1e612
2016-07-29 13:13:55 -05:00
zuul
c7c4fbe0bf Merge "pjproject_bundled: Update for pjproject 2.5.5" into 14 2016-07-29 11:19:08 -05:00
Joshua Colp
6b5058acd8 astconfigparser: Handle case where line is simply a comment.
Change-Id: I2dea5815363f4d787d709228a04f33baee383ef5
2016-07-29 10:35:38 -05:00
zuul
a4771230fe Merge "pbx.c: Allow dangerous functions when adding a hint to dialplan." into 14 2016-07-29 06:55:32 -05:00
Joshua Colp
b1a1ba0a9b Merge "astconfigparser.py: Update with realtime fixes." into 14 2016-07-28 19:17:55 -05:00
Joshua Colp
94a3c1f178 Merge "dsp.c: Add fax and DTMF detection unit tests." into 14 2016-07-28 19:17:42 -05:00
Joshua Colp
baa2629845 Merge "dsp.c: Added descriptive comments to Goertzel calculations." into 14 2016-07-28 19:17:34 -05:00
Joshua Colp
0dcbed074b Merge "dsp.c: Fix incorrect format reference typo." into 14 2016-07-28 19:17:30 -05:00
zuul
6eb9feb707 Merge "dsp.c: Correct DTMF twist dsp.conf documentation." into 14 2016-07-28 19:15:31 -05:00
Corey Farrell
5597193f62 pbx.c: Fix handling of '-' in extension name and callerid
This adds a two strings to ast_exten.  name to go with exten and
cidmatch_display to go with cidmatch.  The new fields contain input used
to add the extension in the first place.  The existing fields now
contain stripped input that excludes insignificant spaces and dashes.
These stripped fields should always be used for comparisons.  The
unstripped fields should normally be used for display, but displaying
stripped values will not cause runtime errors.

Note the actual string is only stored twice if it contains dashes.  If
no dashes are found then both 'char *' fields point to the same memory.
So this change has a minimum effect on memory usage.

The existing functions ast_get_extension_name and
ast_get_extension_cidmatch return unstripped values as they did before
this change.  Other similar bugs likely still exist where unstripped
extensions are saved outside pbx.c then passed back in.

ASTERISK-26233 #close

Change-Id: I6cd61ce57acc1570ca6cc14960c4c3b0a9eb837f
2016-07-28 19:02:29 -05:00
Richard Mudgett
5316f49a2d pbx.c: Allow dangerous functions when adding a hint to dialplan.
We can allow dangerous functions when adding a hint since altering
dialplan is itself a privileged activity.  Otherwise, we could never
execute dangerous functions.

ASTERISK-25996 #close
Reported by: Andrew Nagy

Change-Id: I4929ff100ad1200a0198262d069a34f2296e77ba
2016-07-28 15:11:20 -05:00
zuul
e8d3b8a1ce Merge "rtp_engine: Failed assertion and wrong name given for codec" into 14 2016-07-28 13:18:46 -05:00
zuul
fa45b0f93b Merge "Portably sscanf tv_usec" into 14 2016-07-28 12:47:17 -05:00
Alexei Gradinari
fc24faf1d9 pjproject: fixed a few bugs
This patch fixes the issue in pjsip_tx_data_dec_ref()
when tx_data_destroy can be called more than once,
and checks if invalid value (e.g. NULL) is passed to.

This patch updates array limit checks and docs
in pjsip_evsub_register_pkg() and pjsip_endpt_add_capability().

Change-Id: I4c7a132b9664afaecbd6bf5ea4c951e43e273e40
2016-07-28 12:09:56 -05:00
George Joseph
4cf02b5584 pjproject_bundled: Update for pjproject 2.5.5
Add more --disable-* switches to Makefile.rules including
--disable-opus which was causing bundled pjproject to fail with
"undefined reference" errors in libasteriskpj.

Changed PJ_ENABLE_EXTRA_CHECK to 1.

Removed 2 obsolete patches and added a new one.
The new one was merged by Teluu on 6/27/2016.

ASTERISK-26148 #close

Change-Id: Ib8af6c6a9d31f7238ce65b336134c2efdc855063
2016-07-28 08:07:11 -05:00
David M. Lee
34087b0d43 Portably sscanf tv_usec
In a timeval, tv_usec is defined as a suseconds_t, which could be
different underlying types on different platforms. Instead of trying to
scanf directly into the timeval, scanf into a long int, then copy that
into the timeval.

Change-Id: I29f22d049d3f7746b6c0cc23fbf4293bdaa5eb95
2016-07-27 13:08:48 -05:00
Kevin Harwell
e5529c4493 rtp_engine: Failed assertion and wrong name given for codec
Fixed an assert check that would trigger when the passed in value was negative.
The negative value was being cast to an unsigned value. This resulted in the
check failing.

Also fixed another problem when loading formats in the engine. When setting the
mime type the format's name was being passed in instead of the codec's name.

Change-Id: I1a201cd419ba4d8e9a40d337e36b6fbe1737192c
2016-07-27 12:48:17 -05:00
Richard Mudgett
5f54805e62 dsp.c: Add fax and DTMF detection unit tests.
* Add fax amplitude and frequency sweep tests.
* Add DTMF amplitude and twist unit tests.

Change-Id: I8d77c9a1eec89e440d715f998c928687e870c3f7
2016-07-27 11:03:19 -05:00
Richard Mudgett
ebc2b7695d dsp.c: Added descriptive comments to Goertzel calculations.
* Added doxygen to describe some struct members and what is going on in
the code.

Change-Id: I2ec706a33b52aee42b16dcc356c2bd916a45190d
2016-07-27 11:03:19 -05:00
Richard Mudgett
a7e747918d dsp.c: Fix incorrect format reference typo.
Change-Id: Ia131da3ec29acf385cb43a586a29ecc975eb3896
2016-07-27 11:03:19 -05:00
Richard Mudgett
53b46428d1 dsp.c: Correct DTMF twist dsp.conf documentation.
Change-Id: Idf97e3a72f1edc5fca58f2fa7b20785922be0cae
2016-07-27 11:03:19 -05:00
David M. Lee
47689998a9 Replace strdupa with more portable ast_strdupa
The strdupa function is a GNU extension, and not widely portable. We
have an ast_strdupa function used within Asterisk which is preferred.
I pulled the definition up from menuselect.c into the menuselect.h
header file so it can be shared across menuselect.

Change-Id: I9593c97f78386b47dc1e83201e80cb2f62b36c2e
2016-07-27 10:02:15 -05:00
Joshua Colp
8ea9fd7fa4 astconfigparser.py: Update with realtime fixes.
When configuring SIP URIs in the pjsip.conf file it is
necessary to escape the semicolon so the parser does not
treat it as a comment. This change allows this to work in
the astconfigparser implementation.

A secondary bug where some data was lost if a configuration
option included a "=" in its value was also fixed.

A bug where sections would be considered equal despite
being different has also been fixed.

Change-Id: If229f656ef22050b50e7b34e90c4bffe796431f8
2016-07-26 17:31:11 -05:00
Richard Mudgett
ba449e0242 dsp.c: Fix erroneous fax tone detection.
The Goertzel calculations get less accurate the lower the signal level
being worked with becomes because there is less resolution remaining.
If it is too low we can erroneously detect a tone where none really
exists.  The searched for fax frequencies not only need to be so much
stronger than the background noise they must also be a minimum strength.

* Add needed minimum threshold test to tone_detect().

* Set TONE_THRESHOLD to allow low volume frequency spread detection.

ASTERISK-26237 #close
Reported by: Richard Mudgett

Change-Id: I84dbba7f7628fa13720add6a88eae3b129e066fc
2016-07-26 11:43:16 -05:00
zuul
e7fc209b26 Merge "codecs: Add iLBC 20." into 14 2016-07-26 10:38:10 -05:00
zuul
37e6db2eac Merge "menuselect: Various menuselect enhancements" into 14 2016-07-26 06:39:31 -05:00
zuul
f85a16a681 Merge "asterisk.c: Add auto generation and persistence of UUID" into 14 2016-07-25 21:03:34 -05:00
George Joseph
90f445729d menuselect: Various menuselect enhancements
* Add 'external' as a support level.
* Add ability for module directories to add entries to the menu
  by adding members to the <module_prefix>/<module_prefix>.xml file.
* Expand the description field to 3 lines in the ncurses implementation.
* Allow the description field to wrap in the newt implementation.
* Add description field to the gtk implementation.

Change-Id: I7f9600a1984a42ce0696db574c1051bc9ad7c808
2016-07-25 13:30:54 -06:00
Joshua Colp
f75401b1e3 ari: Update version.
New functionality has been added so the version has been
bumped to one over the 13 version.

Change-Id: I5d30077f62640c0ac83599b4e9a9b657bf184f69
2016-07-24 18:51:25 -03:00
George Joseph
58759bd77c asterisk.c: Add auto generation and persistence of UUID
Upcoming features will require the generation and persistence
of a UUID.

Change-Id: I3ec0062427e133217db6ef496a4216f427c3b92d
2016-07-23 08:04:12 -06:00
Mark Michelson
46b4e673ae Fix sqlalchemy error regarding identifier length.
sqlalchemy was complaining:

sqlalchemy.exc.IdentifierError: Identifier
'ps_contacts_qualifyfreq_exptime' exceeds maximum length of 30
characters

This fixes the problem by changing the index name to be
"ps_contacts_qualifyfreq_exp" instead.

ASTERISK-26227 #close
Reported by Mark Michelson

Change-Id: I0ed784f87504be2a59ee8d3242ef6f625d5ed1a9
2016-07-22 14:46:54 -05:00
Joshua Colp
f8142aba27 Merge "build_tools: Update make_version for 14" into 14 2016-07-22 12:52:59 -05:00
Joshua Colp
804c3e6b9e Merge "res_srtp: Enable AES-256 and AES-GCM." into 14 2016-07-22 11:50:59 -05:00
zuul
5356e307dc Merge "res_pjsip: Whitespace and comment cleanup." into 14 2016-07-22 07:45:21 -05:00
George Joseph
633c34c411 build_tools: Update make_version for 14
Also remove svn stuff

Change-Id: I95d762f7cbbe5eb01117bde8779515d51a0bb06a
2016-07-22 06:02:34 -06:00
zuul
7d17164e6e Merge "chan_dahdi.c: Fix deadlock potential in fax redirection." into 14 2016-07-22 05:26:41 -05:00
zuul
c1bb8a202c Merge "chan_sip.c: Fix deadlock potential in fax redirection." into 14 2016-07-22 05:26:39 -05:00