Compare commits

...

9 Commits

Author SHA1 Message Date
Kevin Harwell
2eb8714f7c Update for certified/11.6-cert16 2016-12-08 15:29:23 -05:00
Kevin Harwell
c54d57a9f6 Update for certified/11.6-cert16 2016-12-08 15:28:50 -05:00
Walter Doekes
93dfe39642 chan_sip: Do not allow non-SP/HTAB between header key and colon.
RFC says SIP headers look like:

    HCOLON  =  *( SP / HTAB ) ":" SWS
    SWS     =  [LWS]                    ; sep whitespace
    LWS     =  [*WSP CRLF] 1*WSP        ; linear whitespace
    WSP     =  SP / HTAB                ; from rfc2234

chan_sip implemented this:

    HCOLON  =  *( LOWCTL / SP ) ":" SWS
    LOWCTL  = %x00-1F                   ; CTL without DEL

This discrepancy meant that SIP proxies in front of Asterisk with
chan_sip could pass on unknown headers with \x00-\x1F in them, which
would be treated by Asterisk as a different (known) header.  For
example, the "To\x01:" header would gladly be forwarded by some proxies
as irrelevant, but chan_sip would treat it as the relevant "To:" header.

Those relying on a SIP proxy to scrub certain headers could mistakenly
get unexpected and unvalidated data fed to Asterisk.

This change fixes so chan_sip only considers SP/HTAB as valid tokens
before the colon, making it agree on the headers with other speakers of
SIP.

ASTERISK-26433 #close
AST-2016-009

Change-Id: I78086fbc524ac733b8f7f78cb423c91075fd489b
(cherry picked from commit 26dd464dbd)
2016-12-08 13:23:58 -06:00
George Joseph
5a25b82527 ChangeLog: Updated for certified/11.6-cert15 2016-09-08 11:38:07 -05:00
George Joseph
2b62f55d11 Release summaries: Add summaries for certified/11.6-cert15 2016-09-08 11:38:05 -05:00
George Joseph
1fedc0585e Release summaries: Remove previous versions 2016-09-08 11:37:55 -05:00
George Joseph
107b121ff8 .version: Update for certified/11.6-cert15 2016-09-08 11:37:55 -05:00
George Joseph
4e3297d0b0 .lastclean: Update for certified/11.6-cert15 2016-09-08 11:37:49 -05:00
Joshua Colp
c7cb8f7808 chan_sip: Don't allocate new RTP instances on top of old ones.
In some scenarios dialog_initialize_rtp can be called multiple times on
the same dialog.  This can cause RTP instances to be leaked along with
multiple file descriptors for each instance.

This change makes it so the existing RTP instances are destroyed and
not overwritten, stopping the memory leak.

ASTERISK-26272 #close
patches:
  ASTERISK-26272-11.patch submitted by Corey Farrell (license 5909)

Change-Id: I3c1d94dea8594fe0702168cb979b898ae0f5fc5d
2016-09-08 09:11:00 -06:00
7 changed files with 249 additions and 364 deletions

View File

@@ -1 +1 @@
certified/11.6-cert14
certified/11.6-cert16

View File

@@ -1,3 +1,79 @@
2016-12-08 20:29 +0000 Asterisk Development Team <asteriskteam@digium.com>
* asterisk certified/11.6-cert16 Released.
2016-12-08 14:28 +0000 [c54d57a9f6] Kevin Harwell <kharwell@digium.com>
* Update for certified/11.6-cert16
2016-11-30 09:31 +0000 [93dfe39642] Walter Doekes <walter+asterisk@wjd.nu>
* chan_sip: Do not allow non-SP/HTAB between header key and colon.
RFC says SIP headers look like:
HCOLON = *( SP / HTAB ) ":" SWS
SWS = [LWS] ; sep whitespace
LWS = [*WSP CRLF] 1*WSP ; linear whitespace
WSP = SP / HTAB ; from rfc2234
chan_sip implemented this:
HCOLON = *( LOWCTL / SP ) ":" SWS
LOWCTL = %x00-1F ; CTL without DEL
This discrepancy meant that SIP proxies in front of Asterisk with
chan_sip could pass on unknown headers with \x00-\x1F in them, which
would be treated by Asterisk as a different (known) header. For
example, the "To\x01:" header would gladly be forwarded by some proxies
as irrelevant, but chan_sip would treat it as the relevant "To:" header.
Those relying on a SIP proxy to scrub certain headers could mistakenly
get unexpected and unvalidated data fed to Asterisk.
This change fixes so chan_sip only considers SP/HTAB as valid tokens
before the colon, making it agree on the headers with other speakers of
SIP.
ASTERISK-26433 #close
AST-2016-009
Change-Id: I78086fbc524ac733b8f7f78cb423c91075fd489b
(cherry picked from commit 26dd464dbd0ad7439bc29ce59ec55903d518ec6e)
2016-09-08 16:38 +0000 Asterisk Development Team <asteriskteam@digium.com>
* asterisk certified/11.6-cert15 Released.
2016-09-08 11:37 +0000 [1fedc0585e] gtjoseph <gjoseph@digium.com>
* Release summaries: Remove previous versions
2016-09-08 11:37 +0000 [107b121ff8] gtjoseph <gjoseph@digium.com>
* .version: Update for certified/11.6-cert15
2016-09-08 11:37 +0000 [4e3297d0b0] gtjoseph <gjoseph@digium.com>
* .lastclean: Update for certified/11.6-cert15
2016-08-23 06:31 +0000 [c7cb8f7808] Corey Farrell <git@cfware.com> (license 5909)
* chan_sip: Don't allocate new RTP instances on top of old ones.
In some scenarios dialog_initialize_rtp can be called multiple times on
the same dialog. This can cause RTP instances to be leaked along with
multiple file descriptors for each instance.
This change makes it so the existing RTP instances are destroyed and
not overwritten, stopping the memory leak.
ASTERISK-26272 #close
patches:
ASTERISK-26272-11.patch submitted by Corey Farrell (license 5909)
Change-Id: I3c1d94dea8594fe0702168cb979b898ae0f5fc5d
2016-08-29 11:22 +0000 Asterisk Development Team <asteriskteam@digium.com>
* asterisk certified/11.6-cert14 Released.

View File

@@ -1,77 +0,0 @@
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><title>Release Summary - asterisk-certified/11.6-cert14</title><h1 align="center"><a name="top">Release Summary</a></h1><h3 align="center">asterisk-certified/11.6-cert14</h3><h3 align="center">Date: 2016-08-29</h3><h3 align="center">&lt;asteriskteam@digium.com&gt;</h3><hr><h2 align="center">Table of Contents</h2><ol>
<li><a href="#summary">Summary</a></li>
<li><a href="#contributors">Contributors</a></li>
<li><a href="#closed_issues">Closed Issues</a></li>
<li><a href="#commits">Other Changes</a></li>
<li><a href="#diffstat">Diffstat</a></li>
</ol><hr><a name="summary"><h2 align="center">Summary</h2></a><center><a href="#top">[Back to Top]</a></center><p>This release is a point release of an existing major version. The changes included were made to address problems that have been identified in this release series, or are minor, backwards compatible new features or improvements. Users should be able to safely upgrade to this version if this release series is already in use. Users considering upgrading from a previous version are strongly encouraged to review the UPGRADE.txt document as well as the CHANGES document for information about upgrading to this release series.</p><p>The data in this summary reflects changes that have been made since the previous release, asterisk-certified/11.6-cert13.</p><hr><a name="contributors"><h2 align="center">Contributors</h2></a><center><a href="#top">[Back to Top]</a></center><p>This table lists the people who have submitted code, those that have tested patches, as well as those that reported issues on the issue tracker that were resolved in this release. For coders, the number is how many of their patches (of any size) were committed into this release. For testers, the number is the number of times their name was listed as assisting with testing a patch. Finally, for reporters, the number is the number of issues that they reported that were affected by commits that went into this release.</p><table width="100%" border="0">
<tr><th width="33%">Coders</th><th width="33%">Testers</th><th width="33%">Reporters</th></tr>
<tr valign="top"><td width="33%">10 Joshua Colp <jcolp@digium.com><br/>7 George Joseph <gjoseph@digium.com><br/>5 Kevin Harwell <kharwell@digium.com><br/>2 gtjoseph <george.joseph@fairview5.com><br/>1 Matt Jordan <mjordan@digium.com><br/>1 Mark Michelson <mmichelson@digium.com><br/>1 Corey Farrell <git@cfware.com><br/></td><td width="33%">2 gtjoseph<br/></td><td width="33%">6 George Joseph <gjoseph@digium.com><br/>1 Ben Smithurst <ben.smithurst@gradwell.com><br/>1 Jeffrey Ollie<br/>1 Joshua Colp <jcolp@digium.com><br/>1 gtjoseph<br/>1 Jeffrey C. Ollie <jeff@ocjtech.us><br/>1 Patrick Laimbock <patrick@laimbock.com><br/>1 Corey Farrell <git@cfware.com><br/>1 zvision <m.zygmuntowicz@quarcom.pl><br/></td></tr>
</table><hr><a name="closed_issues"><h2 align="center">Closed Issues</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a list of all issues from the issue tracker that were closed by changes that went into this release.</p><h3>Bug</h3><h4>Category: Channels/chan_dahdi</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-25494">ASTERISK-25494</a>: build: GCC 5.1.x catches some new const, array bounds and missing paren issues<br/>Reported by: George Joseph<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=0df57f8f36ac1d3fb98237223402c531002c15c4">[0df57f8f36]</a> gtjoseph -- build: GCC 5.1.x catches some new const, array bounds and missing paren issues</li>
</ul><br><h4>Category: Channels/chan_sip/General</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-23013">ASTERISK-23013</a>: [patch] Deadlock between 'sip show channels' command and attended transfer handling<br/>Reported by: Ben Smithurst<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=4dec4b5c17ac3c27508ffe8114af0e1fde57444c">[4dec4b5c17]</a> gtjoseph -- chan_sip: Prevent deadlock when issuing "sip show channels"</li>
</ul><a href="https://issues.asterisk.org/jira/browse/ASTERISK-25494">ASTERISK-25494</a>: build: GCC 5.1.x catches some new const, array bounds and missing paren issues<br/>Reported by: George Joseph<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=0df57f8f36ac1d3fb98237223402c531002c15c4">[0df57f8f36]</a> gtjoseph -- build: GCC 5.1.x catches some new const, array bounds and missing paren issues</li>
</ul><br><h4>Category: Channels/chan_sip/Interoperability</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-26030">ASTERISK-26030</a>: call cut because of double Session-Expires header in re-invite after proxy authentication is required<br/>Reported by: George Joseph<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=e7dacdbba6887f625fb64b2024f83aa0200fd18d">[e7dacdbba6]</a> gtjoseph -- chan_sip: Prevent extra Session-Expires headers from being added</li>
</ul><br><h4>Category: Channels/chan_sip/T.38</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-26179">ASTERISK-26179</a>: chan_sip: Second T.38 request fails<br/>Reported by: Joshua Colp<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=abe901e682b8b947d2beb03e757d7c94a5f5041b">[abe901e682]</a> Joshua Colp -- chan_sip: Handle a request to negotiate T.38 after it is enabled</li>
</ul><br><h4>Category: Channels/chan_skinny</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-25494">ASTERISK-25494</a>: build: GCC 5.1.x catches some new const, array bounds and missing paren issues<br/>Reported by: George Joseph<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=0df57f8f36ac1d3fb98237223402c531002c15c4">[0df57f8f36]</a> gtjoseph -- build: GCC 5.1.x catches some new const, array bounds and missing paren issues</li>
</ul><br><h4>Category: Channels/chan_unistim</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-26138">ASTERISK-26138</a>: chan_unistim: Under FreeBSD, chan_unistim generates a compile error<br/>Reported by: George Joseph<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=2d1e655844c47c5fb03809ee0924454ac4d93bc3">[2d1e655844]</a> gtjoseph -- chan_unistim: Fix memcpy in get_to_address</li>
</ul><br><h4>Category: Core/BuildSystem</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-24932">ASTERISK-24932</a>: Asterisk 13.x does not build with GCC 5.0<br/>Reported by: Jeffrey C. Ollie<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=abb37129d3bb57cdeaf9deab6f0b7235e64ab944">[abb37129d3]</a> gtjoseph -- build: Fixes for gcc 5 compilation</li>
</ul><a href="https://issues.asterisk.org/jira/browse/ASTERISK-26157">ASTERISK-26157</a>: Build: Fix errors highlighted by GCC 6.x<br/>Reported by: George Joseph<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=07fc46490c10c21729e4b3f5a23106327fb3415c">[07fc46490c]</a> gtjoseph -- BuildSystem: Fix a few issues hightlighted by gcc 6.x</li>
</ul><a href="https://issues.asterisk.org/jira/browse/ASTERISK-24502">ASTERISK-24502</a>: Build fails when dev-mode, dont optimize and coverage are enabled<br/>Reported by: Corey Farrell<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=b92332b57517041bc4ac261c4025e7d0c08725c4">[b92332b575]</a> Corey Farrell -- Fix compiler error when using ./configure --enable-dev-mode --enable-coverage</li>
</ul><br><h4>Category: Core/Internationalization</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-23509">ASTERISK-23509</a>: [patch]SayNumber for Polish language tries to play empty files for numbers divisible by 100<br/>Reported by: zvision<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=d99d5c0f8358be6eeec35e49b044099e8d0dfd0f">[d99d5c0f83]</a> Joshua Colp -- say: Fix a bug where SayNumber in Polish tries to play incorrect sound.</li>
</ul><br><h4>Category: Core/UDPTL</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-26034">ASTERISK-26034</a>: T.38 passthrough problem behind firewall due to early nosignal packet<br/>Reported by: George Joseph<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=1597ef14ed4bee3bef044ccb9f78673fec210474">[1597ef14ed]</a> gtjoseph -- udptl: Don't eat sequence numbers until OK is received</li>
</ul><br><h4>Category: Resources/res_rtp_asterisk</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-26140">ASTERISK-26140</a>: res_rtp_asterisk: gcc 6 caught a self-comparison<br/>Reported by: George Joseph<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=c974fab9407d5b180568f9d394e43ca232888809">[c974fab940]</a> gtjoseph -- res_rtp_asterisk: Fix a self-comparison identified by gcc 6</li>
</ul><br><h4>Category: Resources/res_srtp</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-24436">ASTERISK-24436</a>: Missing header in res/res_srtp.c when compiling against libsrtp-1.5.0<br/>Reported by: Patrick Laimbock<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=203fb86874a9ad3a578e35df9517fd4a0bc25496">[203fb86874]</a> Matt Jordan -- res/res_srtp: Fix include issue for libsrtp 1.5.0</li>
</ul><br><hr><a name="commits"><h2 align="center">Commits Not Associated with an Issue</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a list of all changes that went into this release that did not reference a JIRA issue.</p><table width="100%" border="1">
<tr><th>Revision</th><th>Author</th><th>Summary</th></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=5abfbd9874a55adff323dda4a8def7abbd685a13">5abfbd9874</a></td><td>Joshua Colp</td><td>Release summaries: Remove previous versions</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=307aec91964acacb970cedf5dabf0de4aace660d">307aec9196</a></td><td>Joshua Colp</td><td>.version: Update for certified/11.6-cert14</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=65323df2056e43f0b424bf07e4f40f3ebd2dcebf">65323df205</a></td><td>Joshua Colp</td><td>.lastclean: Update for certified/11.6-cert14</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=b20b86c0110ff91b49a6e8fe53872557153fca00">b20b86c011</a></td><td>Kevin Harwell</td><td>ChangeLog: Updated for certified/11.6-cert14-rc2</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=5fe6870fb835d236c277361b432bd04b3f22d5cb">5fe6870fb8</a></td><td>Kevin Harwell</td><td>Release summaries: Add summaries for certified/11.6-cert14-rc2</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=3fce1fc7854303483e746930608f837f31984f5b">3fce1fc785</a></td><td>Kevin Harwell</td><td>Release summaries: Remove previous versions</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=fdb4384ad5ae3eadb74a55912c2315e62f4791f3">fdb4384ad5</a></td><td>Kevin Harwell</td><td>.version: Update for certified/11.6-cert14-rc2</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=3f2b343955d72bd079b44dba456ba049f0e59003">3f2b343955</a></td><td>Kevin Harwell</td><td>.lastclean: Update for certified/11.6-cert14-rc2</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=9f9d7c9fa9c2807545c1c69fd4c834cac0a1c12f">9f9d7c9fa9</a></td><td>Mark Michelson</td><td>res_http_websocket: Enable by default</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=dbaa5a81dbfe8a5f079ca35244cdc227c9e22873">dbaa5a81db</a></td><td>Joshua Colp</td><td>ChangeLog: Updated for certified/11.6-cert14-rc1</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=e95bef471cd9a1c89f15d3b7ed6738fd234b5ae7">e95bef471c</a></td><td>Joshua Colp</td><td>Release summaries: Add summaries for certified/11.6-cert14-rc1</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=8c2f8c4b080539c4161e9487bc3986204da0a8a2">8c2f8c4b08</a></td><td>Joshua Colp</td><td>Release summaries: Remove previous versions</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=c4be815da445cdaa3ff02c48a9534b359b8fbcf2">c4be815da4</a></td><td>Joshua Colp</td><td>.version: Update for certified/11.6-cert14-rc1</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=4bf8df9de3d97a42dc0eeaf538392309d5bc5005">4bf8df9de3</a></td><td>Joshua Colp</td><td>.lastclean: Update for certified/11.6-cert14-rc1</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=9937f60ba78b593091bcb228308054cc0e32c5f4">9937f60ba7</a></td><td>gtjoseph</td><td>build: Fix ast_sockaddr initialization to be more portable</td></tr>
</table><hr><a name="diffstat"><h2 align="center">Diffstat Results</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a summary of the changes to the source code that went into this release that was generated using the diffstat utility.</p><pre>asterisk-certified-11.6-cert13-summary.html | 45 ----
asterisk-certified-11.6-cert13-summary.txt | 161 ----------------
b/.version | 2
b/ChangeLog | 280 ++++++++++++++++++++++++++++
b/Makefile.rules | 18 +
b/channels/chan_agent.c | 6
b/channels/chan_dahdi.c | 5
b/channels/chan_motif.c | 1
b/channels/chan_sip.c | 44 ++--
b/channels/chan_skinny.c | 2
b/channels/chan_unistim.c | 2
b/channels/sig_pri.c | 2
b/funcs/func_env.c | 4
b/main/ccss.c | 2
b/main/dsp.c | 17 +
b/main/manager.c | 2
b/main/say.c | 28 +-
b/main/stdtime/localtime.c | 11 -
b/main/udptl.c | 12 +
b/res/res_http_websocket.c | 2
b/res/res_rtp_asterisk.c | 4
b/res/res_srtp.c | 1
22 files changed, 380 insertions(+), 271 deletions(-)</pre><br></html>

View File

@@ -1,259 +0,0 @@
Release Summary
asterisk-certified/11.6-cert14
Date: 2016-08-29
<asteriskteam@digium.com>
----------------------------------------------------------------------
Table of Contents
1. Summary
2. Contributors
3. Closed Issues
4. Other Changes
5. Diffstat
----------------------------------------------------------------------
Summary
[Back to Top]
This release is a point release of an existing major version. The changes
included were made to address problems that have been identified in this
release series, or are minor, backwards compatible new features or
improvements. Users should be able to safely upgrade to this version if
this release series is already in use. Users considering upgrading from a
previous version are strongly encouraged to review the UPGRADE.txt
document as well as the CHANGES document for information about upgrading
to this release series.
The data in this summary reflects changes that have been made since the
previous release, asterisk-certified/11.6-cert13.
----------------------------------------------------------------------
Contributors
[Back to Top]
This table lists the people who have submitted code, those that have
tested patches, as well as those that reported issues on the issue tracker
that were resolved in this release. For coders, the number is how many of
their patches (of any size) were committed into this release. For testers,
the number is the number of times their name was listed as assisting with
testing a patch. Finally, for reporters, the number is the number of
issues that they reported that were affected by commits that went into
this release.
Coders Testers Reporters
10 Joshua Colp 2 gtjoseph 6 George Joseph
7 George Joseph 1 Ben Smithurst
5 Kevin Harwell 1 Jeffrey Ollie
2 gtjoseph 1 Joshua Colp
1 Matt Jordan 1 gtjoseph
1 Mark Michelson 1 Jeffrey C. Ollie
1 Corey Farrell 1 Patrick Laimbock
1 Corey Farrell
1 zvision
----------------------------------------------------------------------
Closed Issues
[Back to Top]
This is a list of all issues from the issue tracker that were closed by
changes that went into this release.
Bug
Category: Channels/chan_dahdi
ASTERISK-25494: build: GCC 5.1.x catches some new const, array bounds and
missing paren issues
Reported by: George Joseph
* [0df57f8f36] gtjoseph -- build: GCC 5.1.x catches some new const,
array bounds and missing paren issues
Category: Channels/chan_sip/General
ASTERISK-23013: [patch] Deadlock between 'sip show channels' command and
attended transfer handling
Reported by: Ben Smithurst
* [4dec4b5c17] gtjoseph -- chan_sip: Prevent deadlock when issuing "sip
show channels"
ASTERISK-25494: build: GCC 5.1.x catches some new const, array bounds and
missing paren issues
Reported by: George Joseph
* [0df57f8f36] gtjoseph -- build: GCC 5.1.x catches some new const,
array bounds and missing paren issues
Category: Channels/chan_sip/Interoperability
ASTERISK-26030: call cut because of double Session-Expires header in
re-invite after proxy authentication is required
Reported by: George Joseph
* [e7dacdbba6] gtjoseph -- chan_sip: Prevent extra Session-Expires
headers from being added
Category: Channels/chan_sip/T.38
ASTERISK-26179: chan_sip: Second T.38 request fails
Reported by: Joshua Colp
* [abe901e682] Joshua Colp -- chan_sip: Handle a request to negotiate
T.38 after it is enabled
Category: Channels/chan_skinny
ASTERISK-25494: build: GCC 5.1.x catches some new const, array bounds and
missing paren issues
Reported by: George Joseph
* [0df57f8f36] gtjoseph -- build: GCC 5.1.x catches some new const,
array bounds and missing paren issues
Category: Channels/chan_unistim
ASTERISK-26138: chan_unistim: Under FreeBSD, chan_unistim generates a
compile error
Reported by: George Joseph
* [2d1e655844] gtjoseph -- chan_unistim: Fix memcpy in get_to_address
Category: Core/BuildSystem
ASTERISK-24932: Asterisk 13.x does not build with GCC 5.0
Reported by: Jeffrey C. Ollie
* [abb37129d3] gtjoseph -- build: Fixes for gcc 5 compilation
ASTERISK-26157: Build: Fix errors highlighted by GCC 6.x
Reported by: George Joseph
* [07fc46490c] gtjoseph -- BuildSystem: Fix a few issues hightlighted by
gcc 6.x
ASTERISK-24502: Build fails when dev-mode, dont optimize and coverage are
enabled
Reported by: Corey Farrell
* [b92332b575] Corey Farrell -- Fix compiler error when using
./configure --enable-dev-mode --enable-coverage
Category: Core/Internationalization
ASTERISK-23509: [patch]SayNumber for Polish language tries to play empty
files for numbers divisible by 100
Reported by: zvision
* [d99d5c0f83] Joshua Colp -- say: Fix a bug where SayNumber in Polish
tries to play incorrect sound.
Category: Core/UDPTL
ASTERISK-26034: T.38 passthrough problem behind firewall due to early
nosignal packet
Reported by: George Joseph
* [1597ef14ed] gtjoseph -- udptl: Don't eat sequence numbers until OK is
received
Category: Resources/res_rtp_asterisk
ASTERISK-26140: res_rtp_asterisk: gcc 6 caught a self-comparison
Reported by: George Joseph
* [c974fab940] gtjoseph -- res_rtp_asterisk: Fix a self-comparison
identified by gcc 6
Category: Resources/res_srtp
ASTERISK-24436: Missing header in res/res_srtp.c when compiling against
libsrtp-1.5.0
Reported by: Patrick Laimbock
* [203fb86874] Matt Jordan -- res/res_srtp: Fix include issue for
libsrtp 1.5.0
----------------------------------------------------------------------
Commits Not Associated with an Issue
[Back to Top]
This is a list of all changes that went into this release that did not
reference a JIRA issue.
+------------------------------------------------------------------------+
| Revision | Author | Summary |
|------------+----------------+------------------------------------------|
| 5abfbd9874 | Joshua Colp | Release summaries: Remove previous |
| | | versions |
|------------+----------------+------------------------------------------|
| 307aec9196 | Joshua Colp | .version: Update for |
| | | certified/11.6-cert14 |
|------------+----------------+------------------------------------------|
| 65323df205 | Joshua Colp | .lastclean: Update for |
| | | certified/11.6-cert14 |
|------------+----------------+------------------------------------------|
| b20b86c011 | Kevin Harwell | ChangeLog: Updated for |
| | | certified/11.6-cert14-rc2 |
|------------+----------------+------------------------------------------|
| 5fe6870fb8 | Kevin Harwell | Release summaries: Add summaries for |
| | | certified/11.6-cert14-rc2 |
|------------+----------------+------------------------------------------|
| 3fce1fc785 | Kevin Harwell | Release summaries: Remove previous |
| | | versions |
|------------+----------------+------------------------------------------|
| fdb4384ad5 | Kevin Harwell | .version: Update for |
| | | certified/11.6-cert14-rc2 |
|------------+----------------+------------------------------------------|
| 3f2b343955 | Kevin Harwell | .lastclean: Update for |
| | | certified/11.6-cert14-rc2 |
|------------+----------------+------------------------------------------|
| 9f9d7c9fa9 | Mark Michelson | res_http_websocket: Enable by default |
|------------+----------------+------------------------------------------|
| dbaa5a81db | Joshua Colp | ChangeLog: Updated for |
| | | certified/11.6-cert14-rc1 |
|------------+----------------+------------------------------------------|
| e95bef471c | Joshua Colp | Release summaries: Add summaries for |
| | | certified/11.6-cert14-rc1 |
|------------+----------------+------------------------------------------|
| 8c2f8c4b08 | Joshua Colp | Release summaries: Remove previous |
| | | versions |
|------------+----------------+------------------------------------------|
| c4be815da4 | Joshua Colp | .version: Update for |
| | | certified/11.6-cert14-rc1 |
|------------+----------------+------------------------------------------|
| 4bf8df9de3 | Joshua Colp | .lastclean: Update for |
| | | certified/11.6-cert14-rc1 |
|------------+----------------+------------------------------------------|
| 9937f60ba7 | gtjoseph | build: Fix ast_sockaddr initialization |
| | | to be more portable |
+------------------------------------------------------------------------+
----------------------------------------------------------------------
Diffstat Results
[Back to Top]
This is a summary of the changes to the source code that went into this
release that was generated using the diffstat utility.
asterisk-certified-11.6-cert13-summary.html | 45 ----
asterisk-certified-11.6-cert13-summary.txt | 161 ----------------
b/.version | 2
b/ChangeLog | 280 ++++++++++++++++++++++++++++
b/Makefile.rules | 18 +
b/channels/chan_agent.c | 6
b/channels/chan_dahdi.c | 5
b/channels/chan_motif.c | 1
b/channels/chan_sip.c | 44 ++--
b/channels/chan_skinny.c | 2
b/channels/chan_unistim.c | 2
b/channels/sig_pri.c | 2
b/funcs/func_env.c | 4
b/main/ccss.c | 2
b/main/dsp.c | 17 +
b/main/manager.c | 2
b/main/say.c | 28 +-
b/main/stdtime/localtime.c | 11 -
b/main/udptl.c | 12 +
b/res/res_http_websocket.c | 2
b/res/res_rtp_asterisk.c | 4
b/res/res_srtp.c | 1
22 files changed, 380 insertions(+), 271 deletions(-)

View File

@@ -0,0 +1,23 @@
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><title>Release Summary - asterisk-certified/11.6-cert16</title><h1 align="center"><a name="top">Release Summary</a></h1><h3 align="center">asterisk-certified/11.6-cert16</h3><h3 align="center">Date: 2016-12-08</h3><h3 align="center">&lt;asteriskteam@digium.com&gt;</h3><hr><h2 align="center">Table of Contents</h2><ol>
<li><a href="#summary">Summary</a></li>
<li><a href="#contributors">Contributors</a></li>
<li><a href="#closed_issues">Closed Issues</a></li>
<li><a href="#commits">Other Changes</a></li>
<li><a href="#diffstat">Diffstat</a></li>
</ol><hr><a name="summary"><h2 align="center">Summary</h2></a><center><a href="#top">[Back to Top]</a></center><p>This release has been made to address one or more security vulnerabilities that have been identified. A security advisory document has been published for each vulnerability that includes additional information. Users of versions of Asterisk that are affected are strongly encouraged to review the advisories and determine what action they should take to protect their systems from these issues.</p><p>Security Advisories:</p><ul>
<li><a href="http://downloads.asterisk.org/pub/security/AST-2016-009.html">AST-2016-009</a></li>
</ul><p>The data in this summary reflects changes that have been made since the previous release, asterisk-certified/11.6-cert15.</p><hr><a name="contributors"><h2 align="center">Contributors</h2></a><center><a href="#top">[Back to Top]</a></center><p>This table lists the people who have submitted code, those that have tested patches, as well as those that reported issues on the issue tracker that were resolved in this release. For coders, the number is how many of their patches (of any size) were committed into this release. For testers, the number is the number of times their name was listed as assisting with testing a patch. Finally, for reporters, the number is the number of issues that they reported that were affected by commits that went into this release.</p><table width="100%" border="0">
<tr><th width="33%">Coders</th><th width="33%">Testers</th><th width="33%">Reporters</th></tr>
<tr valign="top"><td width="33%">1 Kevin Harwell <kharwell@digium.com><br/>1 Walter Doekes <walter+asterisk@wjd.nu><br/></td><td width="33%"><td width="33%">1 Walter Doekes <walter+asterisk@wjd.nu><br/></td></tr>
</table><hr><a name="closed_issues"><h2 align="center">Closed Issues</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a list of all issues from the issue tracker that were closed by changes that went into this release.</p><h3>Bug</h3><h4>Category: Channels/chan_sip/Interoperability</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-26433">ASTERISK-26433</a>: chan_sip: Allows To-tag checks to be bypassed, setting up new calls<br/>Reported by: Walter Doekes<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=93dfe3964212deb8abbee7ab7f0153c64d660726">[93dfe39642]</a> Walter Doekes -- chan_sip: Do not allow non-SP/HTAB between header key and colon.</li>
</ul><br><hr><a name="commits"><h2 align="center">Commits Not Associated with an Issue</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a list of all changes that went into this release that did not reference a JIRA issue.</p><table width="100%" border="1">
<tr><th>Revision</th><th>Author</th><th>Summary</th></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=c54d57a9f63171a10f2f477bb434f2b2bdcbb5a4">c54d57a9f6</a></td><td>Kevin Harwell</td><td>Update for certified/11.6-cert16</td></tr>
</table><hr><a name="diffstat"><h2 align="center">Diffstat Results</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a summary of the changes to the source code that went into this release that was generated using the diffstat utility.</p><pre>asterisk-certified-11.6-cert15-summary.html | 23 -----
asterisk-certified-11.6-cert15-summary.txt | 108 --------------------------
b/.version | 2
b/ChangeLog | 39 +++++++++
b/asterisk-certified-11.6-cert16-summary.html | 13 +++
b/asterisk-certified-11.6-cert16-summary.txt | 29 ++++++
6 files changed, 82 insertions(+), 132 deletions(-)</pre><br></html>

View File

@@ -0,0 +1,107 @@
Release Summary
asterisk-certified/11.6-cert16
Date: 2016-12-08
<asteriskteam@digium.com>
----------------------------------------------------------------------
Table of Contents
1. Summary
2. Contributors
3. Closed Issues
4. Other Changes
5. Diffstat
----------------------------------------------------------------------
Summary
[Back to Top]
This release has been made to address one or more security vulnerabilities
that have been identified. A security advisory document has been published
for each vulnerability that includes additional information. Users of
versions of Asterisk that are affected are strongly encouraged to review
the advisories and determine what action they should take to protect their
systems from these issues.
Security Advisories:
* AST-2016-009
The data in this summary reflects changes that have been made since the
previous release, asterisk-certified/11.6-cert15.
----------------------------------------------------------------------
Contributors
[Back to Top]
This table lists the people who have submitted code, those that have
tested patches, as well as those that reported issues on the issue tracker
that were resolved in this release. For coders, the number is how many of
their patches (of any size) were committed into this release. For testers,
the number is the number of times their name was listed as assisting with
testing a patch. Finally, for reporters, the number is the number of
issues that they reported that were affected by commits that went into
this release.
Coders Testers Reporters
1 Kevin Harwell 1 Walter Doekes
1 Walter Doekes
----------------------------------------------------------------------
Closed Issues
[Back to Top]
This is a list of all issues from the issue tracker that were closed by
changes that went into this release.
Bug
Category: Channels/chan_sip/Interoperability
ASTERISK-26433: chan_sip: Allows To-tag checks to be bypassed, setting up
new calls
Reported by: Walter Doekes
* [93dfe39642] Walter Doekes -- chan_sip: Do not allow non-SP/HTAB
between header key and colon.
----------------------------------------------------------------------
Commits Not Associated with an Issue
[Back to Top]
This is a list of all changes that went into this release that did not
reference a JIRA issue.
+------------------------------------------------------------------------+
| Revision | Author | Summary |
|---------------+------------------+-------------------------------------|
| c54d57a9f6 | Kevin Harwell | Update for certified/11.6-cert16 |
+------------------------------------------------------------------------+
----------------------------------------------------------------------
Diffstat Results
[Back to Top]
This is a summary of the changes to the source code that went into this
release that was generated using the diffstat utility.
asterisk-certified-11.6-cert15-summary.html | 23 -----
asterisk-certified-11.6-cert15-summary.txt | 108 --------------------------
b/.version | 2
b/ChangeLog | 39 +++++++++
b/asterisk-certified-11.6-cert16-summary.html | 13 +++
b/asterisk-certified-11.6-cert16-summary.txt | 29 ++++++
6 files changed, 82 insertions(+), 132 deletions(-)

View File

@@ -5708,6 +5708,38 @@ static void copy_socket_data(struct sip_socket *to_sock, const struct sip_socket
*to_sock = *from_sock;
}
/*! Cleanup the RTP and SRTP portions of a dialog
*
* \note This procedure excludes vsrtp as it is initialized differently.
*/
static void dialog_clean_rtp(struct sip_pvt *p)
{
if (p->rtp) {
ast_rtp_instance_destroy(p->rtp);
p->rtp = NULL;
}
if (p->vrtp) {
ast_rtp_instance_destroy(p->vrtp);
p->vrtp = NULL;
}
if (p->trtp) {
ast_rtp_instance_destroy(p->trtp);
p->trtp = NULL;
}
if (p->srtp) {
sip_srtp_destroy(p->srtp);
p->srtp = NULL;
}
if (p->tsrtp) {
sip_srtp_destroy(p->tsrtp);
p->tsrtp = NULL;
}
}
/*! \brief Initialize DTLS-SRTP support on an RTP instance */
static int dialog_initialize_dtls_srtp(const struct sip_pvt *dialog, struct ast_rtp_instance *rtp, struct sip_srtp **srtp)
{
@@ -5755,6 +5787,9 @@ static int dialog_initialize_rtp(struct sip_pvt *dialog)
return 0;
}
/* Make sure previous RTP instances/FD's do not leak */
dialog_clean_rtp(dialog);
ast_sockaddr_copy(&bindaddr_tmp, &bindaddr);
if (!(dialog->rtp = ast_rtp_instance_new(dialog->engine, sched, &bindaddr_tmp, NULL))) {
return -1;
@@ -6414,18 +6449,10 @@ void __sip_destroy(struct sip_pvt *p, int lockowner, int lockdialoglist)
ast_free(p->notify);
p->notify = NULL;
}
if (p->rtp) {
ast_rtp_instance_destroy(p->rtp);
p->rtp = NULL;
}
if (p->vrtp) {
ast_rtp_instance_destroy(p->vrtp);
p->vrtp = NULL;
}
if (p->trtp) {
ast_rtp_instance_destroy(p->trtp);
p->trtp = NULL;
}
/* Free RTP and SRTP instances */
dialog_clean_rtp(p);
if (p->udptl) {
ast_udptl_destroy(p->udptl);
p->udptl = NULL;
@@ -6468,21 +6495,11 @@ void __sip_destroy(struct sip_pvt *p, int lockowner, int lockdialoglist)
destroy_msg_headers(p);
if (p->srtp) {
sip_srtp_destroy(p->srtp);
p->srtp = NULL;
}
if (p->vsrtp) {
sip_srtp_destroy(p->vsrtp);
p->vsrtp = NULL;
}
if (p->tsrtp) {
sip_srtp_destroy(p->tsrtp);
p->tsrtp = NULL;
}
if (p->directmediaacl) {
p->directmediaacl = ast_free_acl_list(p->directmediaacl);
}
@@ -8126,8 +8143,6 @@ static const char *__get_header(const struct sip_request *req, const char *name,
* one afterwards. If you shouldn't do it, what absolute idiot decided it was
* a good idea to say you can do it, and if you can do it, why in the hell would.
* you say you shouldn't.
* Anyways, pedanticsipchecking controls whether we allow spaces before ':',
* and we always allow spaces after that for compatibility.
*/
const char *sname = find_alias(name, NULL);
int x, len = strlen(name), slen = (sname ? 1 : 0);
@@ -8140,10 +8155,10 @@ static const char *__get_header(const struct sip_request *req, const char *name,
if (match || smatch) {
/* skip name */
const char *r = header + (match ? len : slen );
if (sip_cfg.pedanticsipchecking) {
r = ast_skip_blanks(r);
/* HCOLON has optional SP/HTAB; skip past those */
while (*r == ' ' || *r == '\t') {
++r;
}
if (*r == ':') {
*start = x+1;
return ast_skip_blanks(r+1);