Commit Graph

24549 Commits

Author SHA1 Message Date
William King 6c3062a768 Removing logically dead code 2013-05-24 19:59:20 -07:00
William King 4edf66be98 If there is a problem reading the dictionary file, don't leak memory... 2013-05-24 19:55:37 -07:00
William King 8803804f90 Removing unused code 2013-05-24 19:53:10 -07:00
William King 47c6981a9f More explicit and defensive code so if the init fails we know we handling this pointer safely, because rc_config_init will free the pointer if there was a problem, but it will not set the pointer to NULL. 2013-05-24 19:49:20 -07:00
William King 6320042f6b Another location where mod_rtmp would leak memory. 2013-05-24 19:45:24 -07:00
William King 83ae82fd2d Fix improper handling of a double linked list that could have caused a memory leak. 2013-05-24 19:42:02 -07:00
William King b3aea78730 Appears to have been a copy paste error because this doesn't do what the api claims, and it also leaks the reference to the new node. 2013-05-24 19:35:43 -07:00
William King 8a743cb2f3 Fixing a memory leak. name needs to be freed since it's being strdup'd lower. 2013-05-24 19:31:40 -07:00
Anthony Minessale aecd186ba5 FS-5470 --resolve 2013-05-24 09:37:40 -05:00
Anthony Minessale dc13cb847f FS-5466 --resolve 2013-05-24 09:14:26 -05:00
Mariusz Czułada e44316d3ea FS-5042 changed event body creation 2013-05-24 09:02:23 -05:00
Raymond Chandler d00ed860a1 FS-4871: reduce logging a bit 2013-05-24 08:34:44 -05:00
Jeff Lenk 4b54ec078b FS-5389 2013-05-24 08:34:43 -05:00
Jeff Lenk b214af4ccf FS-5389 --resolve 2013-05-24 08:34:43 -05:00
Raymond Chandler 1e6d7ea113 FS-4871 --resolve 2013-05-24 08:32:46 -05:00
Anthony Minessale 22076b7b6f FS-5453 --resolve 2013-05-24 08:13:55 -05:00
Anthony Minessale 9c98829aab FS-5453 --resolve this is a different issue, we just have to hangup the loopback channel so the loopback and the sip don't both execute the extension 2013-05-23 09:59:18 -05:00
Anthony Minessale 0060313ea1 swig 2013-05-23 09:55:52 -05:00
Anthony Minessale 18ac2a2540 FS-5042 --resolve 2013-05-23 08:07:26 -05:00
Anthony Minessale 3d2eb20a28 FS-5453 --resolve 2013-05-23 08:06:52 -05:00
Anthony Minessale c08622235d FS-5402 --resolve the problem is ent originate has many channels and many causes to parse so we need to check it against all the causes 2013-05-22 11:01:59 -05:00
Anthony Minessale 666ba36e57 FS-5360 change defaults 2013-05-22 10:20:57 -05:00
Anthony Minessale aed693b9e5 FS-5436 --resolve 2013-05-21 19:39:21 -05:00
Anthony Minessale b73e2c51bb FS-5402 revert wait till tomorrow 2013-05-21 13:29:05 -05:00
Anthony Minessale b6561f2535 FS-5402 2013-05-21 13:22:35 -05:00
Anthony Minessale 1b6860d8e3 FS-5453 --resolve 2013-05-21 12:02:12 -05:00
Anthony Minessale e4f7fda044 FS-5457 2013-05-21 10:22:02 -05:00
Anthony Minessale e2da2e19c3 FS-5376 --resolve 2013-05-21 10:04:58 -05:00
Anthony Minessale fb3eb97568 FS-5242 2013-05-21 10:03:36 -05:00
Anthony Minessale 4bdd2a7f84 FS-5211 --resolve 2013-05-21 09:30:06 -05:00
Anthony Minessale 36116944a7 FS-5360 2013-05-20 12:23:13 -05:00
Anthony Minessale 3a0ec14130 getting read_impl too soon here 2013-05-20 11:22:54 -05:00
Ken Rice b399b3363c 1.2.10 Release 2013-05-20 11:07:35 -05:00
William King 62027c9e7e Add mod_xml_radius to the modules list, though disabled by default. 2013-05-18 20:50:12 -07:00
William King 898a487443 Theoretical memory leak where if attr_init failed, then check would have still been malloc'd but not used. 2013-05-18 20:42:35 -07:00
William King 4192bf3370 Minor code cleanup. calling va_start without calling va_end doesn't leak does it? Either way, it's fixed now. 2013-05-18 20:15:14 -07:00
William King 79e3de3e55 full_contact must be freed by sofia. There isn't a chance of this having blown anything up, but Coverity is right that this should be initialized with NULL to be safe against future refactors. 2013-05-18 19:13:44 -07:00
William King c80d768004 My bad. some how a make didn't catch this issue after a cleanup refactor. In this instance buf is being treated as an 8 byte number, not a pointer. 2013-05-18 17:46:50 -07:00
William King f3393ef362 Coverity reported an Uninitialized pointer read. Upon further digging it appears that there is a code path where incoming packets can come in out of order, so this section of code tries to see if it can find the missed packets. As per FS-5202 there is a case where under heavy load the packet exists, and has most of the packet parsed, but still has a NULL pointer for the packet buffer. These two lines would at least help detect the edge case. 2013-05-18 17:35:07 -07:00
William King bd4ea84242 Edge case for when you are subscribing to presence on a valet parking lot. In which case there would be a small leak. 2013-05-18 17:07:31 -07:00
William King 97286e10cd Possible leak if someone were to try and add extra headers to a channel that had either an inbound info on that session or the session were to be deflected. I don't see a way that these extra headers could be added outside of a C module subscribing to the session states, but just to make sure I'm adding these so that just like other extra header locations it's cleaned up. 2013-05-18 17:01:27 -07:00
William King 14f48a6a7a Alice meet rabit hole. There is a leak here on every invite that comes back from a status 180 when the other side is not FS, but you have presence enabled. Thanks to Coverity scan for location this condition. This 'might' not have been leaking if sofia was automatically freeing this when the sofia object was destroyed, but all other locations where sip_header_as_string where called they were all followed by a su_free, so I assume not. 2013-05-18 16:36:41 -07:00
William King d61d395e8d If the mod_sofia global presense hash is null, then make sure to free the matches variable before going to done. 2013-05-18 16:06:15 -07:00
William King dac6ce1b45 FS-5443: --resolve leaked because the JS api's copy and return new malloc'd pointers. 2013-05-18 15:47:51 -07:00
William King 9ce6ce082f When message events were added, the debug field name was overlooked. This would have only been hit when debug level was above 'DEBUG1' and at that point it would have incorrectly chosen debug display names. 2013-05-18 15:11:14 -07:00
William King 4fc1369a1b Minor typo. User is being passed into this fuction as a long pointer, not a long. 2013-05-18 14:30:43 -07:00
William King 49303fdabc read() does not NULL terminate statbuf, but strstr expects statbuf to be null terminated. 2013-05-18 14:27:00 -07:00
William King 48f423db40 This was writing a null one space to the right, outside of the malloc'd buffer. On further review this uses apr_vsnprintf which always returns null terminated. 2013-05-18 13:39:12 -07:00
Jeff Lenk dec5a592ca FS-5434 --resolve 2013-05-17 21:44:13 -05:00
Anthony Minessale bf688a87aa fix silence_stream size bug 2013-05-17 16:12:13 -05:00