Nathan Neulinger
93a84cf130
FS-6460 --resolve fix leaked RTP ports that cause mod_skinny to fail after N calls
2014-04-14 13:23:05 -05:00
Chris Rienzo
e8078d8aef
mod_rayo: clean up module hashes on shutdown
2014-04-14 12:01:31 -04:00
Chris Rienzo
b0c2c6d67c
FS-6447 --resolve return subscriber-absent platform-code 20 if <dial> is attempted to user that is not registered
2014-04-14 09:47:41 -04:00
Michael Jerris
bb2217901e
FS-6459: --resolve fix srcdir build running modcheck
2014-04-14 08:50:20 -04:00
Peter Olsson
295964f0ec
FS-6457 --resolve
...
Upgrade to OpenSSL 1.0.1g in Windows build (Visual Studio 2010 and 2012)
2014-04-13 10:01:17 +02:00
Travis Cross
2dba7dd367
Avoid leaking memory on mod_cdr_sqlite unload
2014-04-12 06:59:02 +00:00
Travis Cross
39f960a212
Avoid leaking memory on mod_voicemail unload
2014-04-12 06:48:36 +00:00
Travis Cross
886a730ae8
Avoid leaking memory on mod_hash unload
2014-04-12 06:43:11 +00:00
Travis Cross
237da22e22
Avoid leaking memory on unload of mod_dptools
...
Automated leak detectors find leaked memory on shutdown. Cleaning up
after ourselves on shutdown eliminates noise from these reports.
2014-04-12 06:31:31 +00:00
Travis Cross
12af80d6b2
Condense styling a bit
2014-04-12 05:06:51 +00:00
Travis Cross
538cdd378c
Hide warning about sometimes initialized variable
...
The rc variable here was always initialized but the compiler couldn't
see that because of the lack of an unconditional else clause.
2014-04-12 05:02:09 +00:00
Travis Cross
3f8cf4a59d
Fix memory leak in subscription handling
...
We were leaking one event (~539 bytes) for every subscribe packet
received with both an "event: as-feature-event" and an authorization
header.
2014-04-12 05:00:41 +00:00
Travis Cross
06b6e6bdb1
Merge in change to use system libmemcached
...
FS-353
2014-04-11 23:00:59 +00:00
Travis Cross
a60fa6703e
Depend on system libmemcached-dev on Debian
2014-04-11 22:58:43 +00:00
James Le Cuirot
4bdb7129ba
Ungetlib libmemcached
...
Tested with several libmemcached versions between 0.31 and
1.0.18. Unfortunately the API is extremely volatile and awkward to
use. Packaging scripts still need addressing.
FS-353
2014-04-11 22:55:36 +00:00
James Le Cuirot
23fe7f5c9f
Add libyaml pkg-config LIBS to LIBADD not LDFLAGS
...
Per the automake manual these should go in LIBADD.
http://www.gnu.org/software/automake/manual/html_node/Program-and-Library-Variables.html
FS-353
Signed-off-by: Travis Cross <tc@traviscross.com>
2014-04-11 22:53:14 +00:00
James Le Cuirot
c86b939fb3
Show message in configure when YAML isn't there
...
FS-353
Signed-off-by: Travis Cross <tc@traviscross.com>
2014-04-11 22:52:51 +00:00
Peter Olsson
c915139a00
Make sure to copy pcre.h to library path, when building Win32/Debug in VS2012.
2014-04-11 16:35:19 +02:00
Anthony Minessale
38c6e89db0
remove SSML from mod_rss
2014-04-11 03:33:57 +05:00
Anthony Minessale
7428746ce2
FS-6453 --resolve
2014-04-11 03:24:14 +05:00
Anthony Minessale
7e9c350532
avoid recomputing hash
2014-04-11 03:08:27 +05:00
Anthony Minessale
f1d7721710
FS-6448 --resolve revert string func patch cos some things free it
2014-04-11 02:36:13 +05:00
Chris Rienzo
a86623972d
mod_rayo: fixed input crash introduced in 2014-04-07 commit
2014-04-10 10:20:47 -04:00
Travis Cross
b72194b72b
Move loop exit conditionals
...
The net effect here is the code looks more "regular" and reads more
linearly.
2014-04-09 18:41:03 +00:00
Travis Cross
4a8dace5ab
Avoid considering more phrase actions after break
...
Previously we would continue considering phrase actions even after
receiving a break action; we would only break on the next input
clause. It appears the intent here was to break before the next
action.
2014-04-09 18:41:02 +00:00
Travis Cross
75b8f3e0a8
Improve comment
2014-04-09 18:41:02 +00:00
Travis Cross
ffc3f9bb0b
Consolidate two conditionals
...
If we get SWITCH_STATUS_BREAK then we didn't get
SWITCH_STATUS_SUCCESS.
2014-04-09 18:41:02 +00:00
Travis Cross
549aba0d2f
Remove variable assignment without effect
...
We're breaking out of the loop here anyway, so setting done to true is
useless.
2014-04-09 18:41:02 +00:00
Travis Cross
2ace7bc79b
Fix memory leak in phrase macro playback
...
We were leaking memory when break_on_match was set or when we received
back SWITCH_STATUS_BREAK from a callee as we were failing to free
field_expanded_alloc.
2014-04-09 18:41:02 +00:00
Travis Cross
f83d6770ff
Remove tautological conditional
...
If pattern is null we're setting it to a non-null value, so this
branch will always be taken.
Use `git diff -w` or `git log -p -w` to see what's going on in this
commit.
2014-04-09 18:41:02 +00:00
Travis Cross
1a71cf886e
Fix memory leak on memory error
...
In the event of a memory error, we were trying to free a null pointer
while leaking the allocation for field_expanded_alloc.
2014-04-09 18:41:02 +00:00
Travis Cross
a0b8d92219
Move variables down into loop where they're used
...
These variables aren't used outside of this for loop, so they should
be declared within it.
2014-04-09 18:41:01 +00:00
Anthony Minessale
4178688b4a
add switch_hashtable_insert_destructor so you can insert a pointer into a hash with a custom destructor and use it in spandsp to fix a leak on reloadxml with the tone_descriptor tables and fix a bunch of random tiny leaks etc
2014-04-09 23:26:47 +05:00
Anthony Minessale
d789c6470a
free global pool on shutdown
2014-04-09 23:26:47 +05:00
Anthony Minessale
0449baca59
clear event queue on shutdown
2014-04-09 23:26:46 +05:00
Travis Cross
2d811e0ba0
Suppress spurious warning in phrase macro playback
...
Prior to this commit, if anything at all went wrong in
switch_ivr_phrase_macro_event() we would generate a warning like this:
[WARNING] switch_ivr_play_say.c:348 Macro [macro_name]: 'pattern_name' did not match any patterns
This is clearly misleading. The natural thing to do on seeing that
message is to verify that the language files are there, and that the
pattern really does exist in that macro. But none of that was usually
the problem. The message would be generated if the language wasn't
found, or if the channel had gone away, for example.
With this commit, we verify that we actually tried looking for the
pattern before displaying the warning about the pattern not matching.
2014-04-09 04:48:09 +00:00
Travis Cross
1e273e514d
Avoid playback on dead channels in voicemail
...
For years we've been generating spurious messages like:
[WARNING] switch_ivr_play_say.c:348 Macro [voicemail_ack]: 'saved' did not match any patterns
This would happen when the caller hangs up during the playback of
certain prompts in the voicemail system where we weren't checking the
return value of vm_macro_get(). Looking closely at the log, it's
clear we were calling down into switch_ivr_phrase_macro() long after
the channel was gone.
The message above is also misleading -- switch_ivr_phrase_macro()
would have been able to find that pattern just fine, but it never
actually looked because the channel was gone. We'll clean up that
message in a follow on commit.
2014-04-09 04:46:47 +00:00
Travis Cross
f754057c2a
Avoid crash on event without content-type
...
If we received an event without a content-type header we were
dereferencing a null pointer leading to a seg fault.
Reported-by: Ico <ico@voip-io.org>
ESL-90 --resolve
2014-04-09 01:20:07 +00:00
Travis Cross
c6acddf928
Fix typo in comment
2014-04-08 23:17:12 +00:00
Anthony Minessale
369bb55d15
remove unnecessary pool create
2014-04-09 03:18:21 +05:00
Anthony Minessale
53c77f8434
force srtp rebuild
2014-04-09 03:14:52 +05:00
Travis Cross
1636550176
Add immediate sanity check on untrusted length
...
We were actually checking this indirectly in the loop that follows,
but it's more clear to check this immediately and directly.
2014-04-08 21:08:02 +00:00
William King
711e49c46a
Don't leak these 4 hash tables when mod_fifo is reloaded
2014-04-08 11:18:23 -07:00
William King
aae1954c07
FS-6442 --resolve
2014-04-08 10:36:36 -07:00
Dmitry Sobinov
80e203442a
- fixed read of memory out of 'seq' variable bounds
...
- fixed AEAD IV calculation for big-endian machines
2014-04-08 16:13:52 +00:00
Brian West
de7d5a9e07
Resolve key length issue with AES GCM 128/256
2014-04-08 11:04:41 -05:00
Ken Rice
0fdf32a3ae
FS-6436 test cimmit for git hooks
2014-04-08 10:50:15 -05:00
Anthony Minessale
72c52052dc
FS-6436
2014-04-08 20:30:23 +05:00
jfigus
a31491d5b6
This commit resolves issue #46 . The GCM mode was using the wrong master SALT length. The master SALT should be 96 bits instead of 112 bits. Note, GCM mode uses the legacy CTR mode for the KDF. The legagacy CTR mode cipher implementations assume a 112 bit SALT. Changes to the cipher abstraction layer API are required to provide the ability to specify the SALT length. For now this commit modifies the SRTP layer to ensure the SALT is zero-appended before initializing the KDF. This commit also provides public definitions for the GCM cipher suite master key sizes to avoid confusion for application developers.
2014-04-08 15:25:39 +00:00
Brian West
7bc92a11af
ESL-89: fix install path and single_command require
2014-04-07 15:26:13 -05:00